[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/24] scsi-disk: ensure that FORMAT UNIT commands are terminated
|
From: |
Paolo Bonzini |
|
Subject: |
[PULL 10/24] scsi-disk: ensure that FORMAT UNIT commands are terminated |
|
Date: |
Tue, 3 Oct 2023 10:30:27 +0200 |
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Otherwise when a FORMAT UNIT command is issued, the SCSI layer can become
confused because it can find itself in the situation where it thinks there
is still data to be transferred which can cause the next emulated SCSI
command to fail.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Fixes: 6ab71761 ("scsi-disk: add FORMAT UNIT command")
Tested-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20230913204410.65650-4-mark.cave-ayland@ilande.co.uk>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi/scsi-disk.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 477ee2bcd47..6691f5edb84 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -1959,6 +1959,10 @@ static void scsi_disk_emulate_write_data(SCSIRequest
*req)
scsi_disk_emulate_write_same(r, r->iov.iov_base);
break;
+ case FORMAT_UNIT:
+ scsi_req_complete(&r->req, GOOD);
+ break;
+
default:
abort();
}
--
2.41.0
- [PULL 00/24] Audio, build system, misc fixes for 2023-10-03, Paolo Bonzini, 2023/10/03
- [PULL 01/24] optionrom: Remove build-id section, Paolo Bonzini, 2023/10/03
- [PULL 06/24] meson: clean up static_library keyword arguments, Paolo Bonzini, 2023/10/03
- [PULL 02/24] accel/kvm/kvm-all: Handle register access errors, Paolo Bonzini, 2023/10/03
- [PULL 03/24] e1000: remove old compatibility code, Paolo Bonzini, 2023/10/03
- [PULL 07/24] Makefile: build plugins before running TCG tests, Paolo Bonzini, 2023/10/03
- [PULL 11/24] crypto: only include tls-cipher-suites in emulators, Paolo Bonzini, 2023/10/03
- [PULL 12/24] ui/vnc: Require audiodev= to enable audio, Paolo Bonzini, 2023/10/03
- [PULL 05/24] make-release: do not ship dtc sources, Paolo Bonzini, 2023/10/03
- [PULL 10/24] scsi-disk: ensure that FORMAT UNIT commands are terminated,
Paolo Bonzini <=
- [PULL 21/24] hw/ppc: Support machine-default audiodev with fallback, Paolo Bonzini, 2023/10/03
- [PULL 08/24] esp: use correct type for esp_dma_enable() in sysbus_esp_gpio_demux(), Paolo Bonzini, 2023/10/03
- [PULL 15/24] audio: return Error ** from audio_state_by_name, Paolo Bonzini, 2023/10/03
- [PULL 16/24] audio: commonize voice initialization, Paolo Bonzini, 2023/10/03
- [PULL 19/24] Introduce machine property "audiodev", Paolo Bonzini, 2023/10/03
- [PULL 17/24] audio: simplify flow in audio_init, Paolo Bonzini, 2023/10/03
- [PULL 04/24] pc: remove short_root_bus property, Paolo Bonzini, 2023/10/03
- [PULL 22/24] vt82c686 machines: Support machine-default audiodev with fallback, Paolo Bonzini, 2023/10/03
- [PULL 20/24] hw/arm: Support machine-default audiodev with fallback, Paolo Bonzini, 2023/10/03
- [PULL 13/24] audio: Require AudioState in AUD_add_capture, Paolo Bonzini, 2023/10/03