[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 6/7] accel/tcg: Have tcg_exec_realizefn() return a boolean
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
[PATCH v2 6/7] accel/tcg: Have tcg_exec_realizefn() return a boolean |
|
Date: |
Tue, 3 Oct 2023 14:30:24 +0200 |
Following the example documented since commit e3fe3988d7 ("error:
Document Error API usage rules"), have tcg_exec_realizefn() return
a boolean indicating whether an error is set or not.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
---
include/exec/cpu-all.h | 2 +-
accel/tcg/cpu-exec.c | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
index c2c62160c6..1e5c530ee1 100644
--- a/include/exec/cpu-all.h
+++ b/include/exec/cpu-all.h
@@ -422,7 +422,7 @@ void dump_exec_info(GString *buf);
/* accel/tcg/cpu-exec.c */
int cpu_exec(CPUState *cpu);
-void tcg_exec_realizefn(CPUState *cpu, Error **errp);
+bool tcg_exec_realizefn(CPUState *cpu, Error **errp);
void tcg_exec_unrealizefn(CPUState *cpu);
/**
diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index c724e8b6f1..60f1986b85 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/tcg/cpu-exec.c
@@ -1088,7 +1088,7 @@ int cpu_exec(CPUState *cpu)
return ret;
}
-void tcg_exec_realizefn(CPUState *cpu, Error **errp)
+bool tcg_exec_realizefn(CPUState *cpu, Error **errp)
{
static bool tcg_target_initialized;
CPUClass *cc = CPU_GET_CLASS(cpu);
@@ -1104,6 +1104,8 @@ void tcg_exec_realizefn(CPUState *cpu, Error **errp)
tcg_iommu_init_notifier_list(cpu);
#endif /* !CONFIG_USER_ONLY */
/* qemu_plugin_vcpu_init_hook delayed until cpu_index assigned. */
+
+ return true;
}
/* undo the initializations in reverse order */
--
2.41.0
- [PATCH v2 0/7] accel: Restrict tcg_exec_[un]realizefn() to TCG, Philippe Mathieu-Daudé, 2023/10/03
- [PATCH v2 1/7] accel: Rename accel_cpu_realizefn() -> accel_cpu_realize(), Philippe Mathieu-Daudé, 2023/10/03
- [PATCH v2 2/7] accel: Rename AccelCPUClass::cpu_realizefn() -> cpu_target_realize(), Philippe Mathieu-Daudé, 2023/10/03
- [PATCH v2 4/7] accel: Introduce accel_cpu_common_unrealize() stub, Philippe Mathieu-Daudé, 2023/10/03
- [PATCH v2 3/7] accel: Rename accel_cpu_realize() -> accel_cpu_common_realize(), Philippe Mathieu-Daudé, 2023/10/03
- [PATCH v2 6/7] accel/tcg: Have tcg_exec_realizefn() return a boolean,
Philippe Mathieu-Daudé <=
- [PATCH v2 5/7] accel: Declare AccelClass::cpu_common_[un]realize() handlers, Philippe Mathieu-Daudé, 2023/10/03
- [PATCH v2 7/7] accel/tcg: Restrict tcg_exec_[un]realizefn() to TCG, Philippe Mathieu-Daudé, 2023/10/03
- Re: [PATCH v2 0/7] accel: Restrict tcg_exec_[un]realizefn() to TCG, Claudio Fontana, 2023/10/03
- Re: [PATCH v2 0/7] accel: Restrict tcg_exec_[un]realizefn() to TCG, Richard Henderson, 2023/10/03