[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs
|
From: |
Fan Ni |
|
Subject: |
Re: [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs |
|
Date: |
Tue, 3 Oct 2023 17:20:14 +0000 |
On Fri, Sep 29, 2023 at 09:50:16AM +0200, Markus Armbruster wrote:
> Jonathan Cameron <Jonathan.Cameron@Huawei.com> writes:
>
> > On Wed, 27 Sep 2023 19:13:35 +0000
> > Fan Ni <fan.ni@samsung.com> wrote:
> >
> >> On Mon, Sep 25, 2023 at 04:22:58PM +0100, Jonathan Cameron wrote:
> >>
> >> > Rename the version not burried in the macro to cap_h.
> >> The change looks good to me. Just one minor thing. why "version" get
> >> involved here?
> >>
> >
> > Used in the sense of two copies of something with slightly differences
> > given if it were straight code without a macro, we'd have just
> > have used the copy being changed here for all of the calls.
> > With hindsight, not the best word to choose given the many other meanings!
>
> Fan, good enough to get your R-by?
>
Yes.
Fan