[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 2/9] linux-user: Exit not abort in die_with_backtrace
|
From: |
Richard Henderson |
|
Subject: |
[PATCH v5 2/9] linux-user: Exit not abort in die_with_backtrace |
|
Date: |
Tue, 3 Oct 2023 12:20:05 -0700 |
This line is supposed to be unreachable, but if we're going to
have it at all, SIGABRT via abort() is subject to the same signal
peril that created this function in the first place.
We can _exit immediately without peril.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/signal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index b7a2c47837..84a56b76cc 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -713,7 +713,7 @@ void die_with_signal(int host_sig)
sigsuspend(&act.sa_mask);
/* unreachable */
- abort();
+ _exit(EXIT_FAILURE);
}
static G_NORETURN
--
2.34.1
- [PATCH v5 0/9] linux-user: Detect and report host crashes, Richard Henderson, 2023/10/03
- [PATCH v5 4/9] linux-user: Only register handlers for core_dump_signal by default, Richard Henderson, 2023/10/03
- [PATCH v5 9/9] linux-user: Remap guest SIGABRT, Richard Henderson, 2023/10/03
- [PATCH v5 6/9] linux-user: Simplify signal_init, Richard Henderson, 2023/10/03
- [PATCH v5 3/9] linux-user: Detect and report host crashes, Richard Henderson, 2023/10/03
- [PATCH v5 2/9] linux-user: Exit not abort in die_with_backtrace,
Richard Henderson <=
- [PATCH v5 7/9] linux-user: Split out host_sig{segv,bus}_handler, Richard Henderson, 2023/10/03
- [PATCH v5 5/9] linux-user: Map unsupported signals to an out-of-bounds value, Richard Henderson, 2023/10/03
- [PATCH v5 8/9] linux-user: Detect and report host SIGILL, SIGFPE, SIGTRAP, Richard Henderson, 2023/10/03
- [PATCH v5 1/9] linux-user: Split out die_with_signal, Richard Henderson, 2023/10/03
- Re: [PATCH v5 0/9] linux-user: Detect and report host crashes, Richard Henderson, 2023/10/12