[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 11/51] bsd-user: Implement getgroups(2) and setgroups(2) system ca
|
From: |
Warner Losh |
|
Subject: |
[PULL 11/51] bsd-user: Implement getgroups(2) and setgroups(2) system calls. |
|
Date: |
Tue, 3 Oct 2023 17:31:35 -0600 |
From: Stacey Son <sson@FreeBSD.org>
Signed-off-by: Stacey Son <sson@FreeBSD.org>
Signed-off-by: Karim Taha <kariem.taha2.7@gmail.com>
Reviewed-by: Warner Losh <imp@bsdimp.com>
Message-Id: <20230925182425.3163-12-kariem.taha2.7@gmail.com>
---
bsd-user/bsd-proc.h | 44 +++++++++++++++++++++++++++++++++++
bsd-user/freebsd/os-syscall.c | 9 +++++++
2 files changed, 53 insertions(+)
diff --git a/bsd-user/bsd-proc.h b/bsd-user/bsd-proc.h
index b6225e520ea..7b25aa19829 100644
--- a/bsd-user/bsd-proc.h
+++ b/bsd-user/bsd-proc.h
@@ -41,4 +41,48 @@ static inline abi_long do_bsd_exit(void *cpu_env, abi_long
arg1)
return 0;
}
+/* getgroups(2) */
+static inline abi_long do_bsd_getgroups(abi_long gidsetsize, abi_long arg2)
+{
+ abi_long ret;
+ uint32_t *target_grouplist;
+ g_autofree gid_t *grouplist;
+ int i;
+
+ grouplist = g_try_new(gid_t, gidsetsize);
+ ret = get_errno(getgroups(gidsetsize, grouplist));
+ if (gidsetsize != 0) {
+ if (!is_error(ret)) {
+ target_grouplist = lock_user(VERIFY_WRITE, arg2, gidsetsize * 2,
0);
+ if (!target_grouplist) {
+ return -TARGET_EFAULT;
+ }
+ for (i = 0; i < ret; i++) {
+ target_grouplist[i] = tswap32(grouplist[i]);
+ }
+ unlock_user(target_grouplist, arg2, gidsetsize * 2);
+ }
+ }
+ return ret;
+}
+
+/* setgroups(2) */
+static inline abi_long do_bsd_setgroups(abi_long gidsetsize, abi_long arg2)
+{
+ uint32_t *target_grouplist;
+ g_autofree gid_t *grouplist;
+ int i;
+
+ grouplist = g_try_new(gid_t, gidsetsize);
+ target_grouplist = lock_user(VERIFY_READ, arg2, gidsetsize * 2, 1);
+ if (!target_grouplist) {
+ return -TARGET_EFAULT;
+ }
+ for (i = 0; i < gidsetsize; i++) {
+ grouplist[i] = tswap32(target_grouplist[i]);
+ }
+ unlock_user(target_grouplist, arg2, 0);
+ return get_errno(setgroups(gidsetsize, grouplist));
+}
+
#endif /* !BSD_PROC_H_ */
diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c
index fa60df529ef..535e6287bde 100644
--- a/bsd-user/freebsd/os-syscall.c
+++ b/bsd-user/freebsd/os-syscall.c
@@ -223,6 +223,15 @@ static abi_long freebsd_syscall(void *cpu_env, int num,
abi_long arg1,
ret = do_bsd_exit(cpu_env, arg1);
break;
+ case TARGET_FREEBSD_NR_getgroups: /* getgroups(2) */
+ ret = do_bsd_getgroups(arg1, arg2);
+ break;
+
+ case TARGET_FREEBSD_NR_setgroups: /* setgroups(2) */
+ ret = do_bsd_setgroups(arg1, arg2);
+ break;
+
+
/*
* File system calls.
*/
--
2.41.0
- [PULL 01/51] bsd-user: define TARGET_RFSPAWN for rfork to use vfork(2) semantics, and fix RLIM_INFINITY, (continued)
- [PULL 01/51] bsd-user: define TARGET_RFSPAWN for rfork to use vfork(2) semantics, and fix RLIM_INFINITY, Warner Losh, 2023/10/03
- [PULL 03/51] bsd-user: Implement host_to_target_siginfo., Warner Losh, 2023/10/03
- [PULL 05/51] bsd-user: add extern declarations for bsd-proc.c conversion functions, Warner Losh, 2023/10/03
- [PULL 02/51] bsd-user: Define procctl(2) related structs, Warner Losh, 2023/10/03
- [PULL 07/51] bsd-user: Implement target_to_host_rlim and host_to_target_rlim conversion., Warner Losh, 2023/10/03
- [PULL 06/51] bsd-user: Implement target_to_host_resource conversion function, Warner Losh, 2023/10/03
- [PULL 08/51] bsd-user: Implement host_to_target_rusage and host_to_target_wrusage., Warner Losh, 2023/10/03
- [PULL 10/51] bsd-user: Get number of cpus., Warner Losh, 2023/10/03
- [PULL 09/51] bsd-user: Implement host_to_target_waitstatus conversion., Warner Losh, 2023/10/03
- [PULL 13/51] bsd-user: Implement getrusage(2)., Warner Losh, 2023/10/03
- [PULL 11/51] bsd-user: Implement getgroups(2) and setgroups(2) system calls.,
Warner Losh <=
- [PULL 12/51] bsd-user: Implement umask(2), setlogin(2) and getlogin(2), Warner Losh, 2023/10/03
- [PULL 04/51] bsd-user: Add freebsd_exec_common and do_freebsd_procctl to qemu.h., Warner Losh, 2023/10/03
- [PULL 14/51] bsd-user: Implement getrlimit(2) and setrlimit(2), Warner Losh, 2023/10/03
- [PULL 15/51] bsd-user: Implement several get/set system calls:, Warner Losh, 2023/10/03
- [PULL 17/51] bsd-user: Add stubs for profil(2), ktrace(2), utrace(2) and ptrace(2)., Warner Losh, 2023/10/03
- [PULL 18/51] bsd-user: Implement getpriority(2) and setpriority(2)., Warner Losh, 2023/10/03
- [PULL 16/51] bsd-user: Implement get/set[resuid/resgid/sid] and issetugid., Warner Losh, 2023/10/03
- [PULL 20/51] bsd-user: Implement freebsd_exec_common, used in implementing execve/fexecve., Warner Losh, 2023/10/03
- [PULL 19/51] bsd-user: Implement get_filename_from_fd., Warner Losh, 2023/10/03
- [PULL 23/51] bsd-user: Implement wait4(2) and wait6(2) system calls., Warner Losh, 2023/10/03