Re: [PATCH v3 1/7] vhost-user: strip superfluous whitespace

[Michael S. Tsirkin]

On Wed, Oct 04, 2023 at 12:08:52PM +0200, Laszlo Ersek wrote:
> On 10/4/23 11:06, Michael S. Tsirkin wrote:
> > On Mon, Oct 02, 2023 at 10:32:15PM +0200, Laszlo Ersek wrote:
> >> Cc: "Michael S. Tsirkin" <mst@redhat.com> (supporter:vhost)
> > 
> > why the (supporter:vhost) part? not all scripts will cope
> > well with text after the mail. If you really want to keep
> > it around, I think you should add a hash tag # before that -
> > more tools know to ignore that.
> 
> It looked too tiresome to strip all these comments, plus I expected
> that, if the get_maintainer.pl script output these lines, they were fit
> for inclusion in "Cc:" tags in the commit message.
> 
> If they're not, then the tool should indeed insert a # in-between, or
> else provide the explanation for each name+email printed on separate
> (preceding) lines, potentially prefixed with "#". That makes for easy
> human reading and also for easy machine reading (filtering them out).
> 
> Laszlo

/me shrugs

get_maintainer.pl doesn't output Cc tags either. Just pipe to
sed 's/(.*//' ?

> > 
> > 
> >> Cc: Eugenio Perez Martin <eperezma@redhat.com>
> >> Cc: German Maglione <gmaglione@redhat.com>
> >> Cc: Liu Jiang <gerry@linux.alibaba.com>
> >> Cc: Sergio Lopez Pascual <slp@redhat.com>
> >> Cc: Stefano Garzarella <sgarzare@redhat.com>
> >> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> >> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
> >> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> >> Tested-by: Albert Esteve <aesteve@redhat.com>
> >> Reviewed-by: Eugenio Pérez <eperezma@redhat.com>
> >> ---
> >>
> >> Notes:
> >>     v3:
> >>     
> >>     - pick up R-b from Phil and Eugenio, T-b from Albert
> >>     
> >>     v2:
> >>     
> >>     - pick up Stefano's R-b
> >>
> >>  hw/virtio/vhost-user.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> >> index 8dcf049d422b..b4b677c1ce66 100644
> >> --- a/hw/virtio/vhost-user.c
> >> +++ b/hw/virtio/vhost-user.c
> >> @@ -398,7 +398,7 @@ static int vhost_user_write(struct vhost_dev *dev, 
> >> VhostUserMsg *msg,
> >>       * operations such as configuring device memory mappings or issuing 
> >> device
> >>       * resets, which affect the whole device instead of individual VQs,
> >>       * vhost-user messages should only be sent once.
> >> -     * 
> >> +     *
> >>       * Devices with multiple vhost_devs are given an associated 
> >> dev->vq_index
> >>       * so per_device requests are only sent if vq_index is 0.
> >>       */
> >>
> >