[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 19/53] migration/rdma: Replace dangerous macro CHECK_ERROR
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH v2 19/53] migration/rdma: Replace dangerous macro CHECK_ERROR_STATE() |
|
Date: |
Wed, 04 Oct 2023 17:10:27 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> wrote:
> Hiding return statements in macros is a bad idea. Use a function
> instead, and open code the return part.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Fabiano Rosas <farosas@suse.de>
> Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
I hated this macro, thanks.
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 19/53] migration/rdma: Replace dangerous macro CHECK_ERROR_STATE(),
Juan Quintela <=