[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qtest/migration: Add a test for the analyze-migration script
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH] qtest/migration: Add a test for the analyze-migration script |
|
Date: |
Wed, 4 Oct 2023 16:40:43 -0400 |
On Wed, Sep 27, 2023 at 06:47:56PM -0300, Fabiano Rosas wrote:
> I know this adds a python dependency to qtests and I'm not sure how
> much we care about this script, but on the other hand it would be nice
> to catch these errors early on.
>
> This would also help with future work that touches the migration
> stream (moving multifd out of ram.c and fixed-ram).
>
> Let me know what you think.
The test is good, but I think it'll be definitely less burden and cleaner
if it can be written just in shell scripts.. that can even be put in a
single line..
$ (echo "migrate exec:cat>$IMAGE"; echo "quit") | $QEMU_BIN -monitor stdio;
$DIR/scripts/analyze-migration.py -f $IMAGE
Any chance to hook that in?
Thanks,
--
Peter Xu
- Re: [PATCH] qtest/migration: Add a test for the analyze-migration script,
Peter Xu <=