[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 03/14] scripts/cpu-x86-uarch-abi.py: use .command() instead of
|
From: |
Vladimir Sementsov-Ogievskiy |
|
Subject: |
[PATCH v6 03/14] scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd() |
|
Date: |
Thu, 5 Oct 2023 16:55:39 +0300 |
Here we don't expect a failure. In case on failure we'll crash on
trying to access ['return']. Let's better use .command() that clearly
raise on failure.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
scripts/cpu-x86-uarch-abi.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/scripts/cpu-x86-uarch-abi.py b/scripts/cpu-x86-uarch-abi.py
index 82ff07582f..893afd1b35 100644
--- a/scripts/cpu-x86-uarch-abi.py
+++ b/scripts/cpu-x86-uarch-abi.py
@@ -69,7 +69,7 @@
shell = QEMUMonitorProtocol(sock)
shell.connect()
-models = shell.cmd("query-cpu-definitions")
+models = shell.command("query-cpu-definitions")
# These QMP props don't correspond to CPUID fatures
# so ignore them
@@ -85,7 +85,7 @@
names = []
-for model in models["return"]:
+for model in models:
if "alias-of" in model:
continue
names.append(model["name"])
@@ -93,12 +93,12 @@
models = {}
for name in sorted(names):
- cpu = shell.cmd("query-cpu-model-expansion",
- { "type": "static",
- "model": { "name": name }})
+ cpu = shell.command("query-cpu-model-expansion",
+ { "type": "static",
+ "model": { "name": name }})
got = {}
- for (feature, present) in cpu["return"]["model"]["props"].items():
+ for (feature, present) in cpu["model"]["props"].items():
if present and feature not in skip:
got[feature] = True
--
2.34.1
- [PATCH v6 00/14] iotests: use vm.cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 03/14] scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd(),
Vladimir Sementsov-Ogievskiy <=
- [PATCH v6 02/14] qmp_shell.py: _fill_completion() use .command() instead of .cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 01/14] python/qemu/qmp/legacy: cmd(): drop cmd_id unused argument, Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 08/14] iotests: add some missed checks of qmp result, Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 10/14] iotests: drop some occasional semicolons, Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 06/14] python/machine.py: upgrade vm.cmd() method, Vladimir Sementsov-Ogievskiy, 2023/10/05