Re: [PATCH 03/10] tcg/arm: Use tcg_use_softmmu

[Philippe Mathieu-Daudé]

On 3/10/23 19:43, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/arm/tcg-target.c.inc | 203 +++++++++++++++++++--------------------
>   1 file changed, 97 insertions(+), 106 deletions(-)


> @@ -356,14 +354,8 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int type,
>    * r0-r3 will be overwritten when reading the tlb entry (softmmu only);
>    * r14 will be overwritten by the BLNE branching to the slow path.
>    */
> -#ifdef CONFIG_SOFTMMU
>   #define ALL_QLDST_REGS \
> -    (ALL_GENERAL_REGS & ~((1 << TCG_REG_R0) | (1 << TCG_REG_R1) | \
> -                          (1 << TCG_REG_R2) | (1 << TCG_REG_R3) | \
> -                          (1 << TCG_REG_R14)))
> -#else
> -#define ALL_QLDST_REGS   (ALL_GENERAL_REGS & ~(1 << TCG_REG_R14))
> -#endif
> +    (ALL_GENERAL_REGS & ~((tcg_use_softmmu ? 0xf : 0) | (1 << TCG_REG_R14)))

Maybe add a comment?

(ALL_GENERAL_REGS & ~((tcg_use_softmmu ? 0xf /* R0 to R3 */ : 0) | (1 << 
TCG_REG_R14)))

Otherwise,
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>