Re: [PATCH v3 10/10] tests/migration-test: Add a test for postcopy hangs during RECOVER

[Fabiano Rosas]

Peter Xu <peterx@redhat.com> writes:

> On Thu, Oct 05, 2023 at 10:37:56AM -0300, Fabiano Rosas wrote:
>> >> +    /*
>> >> +     * Make sure both QEMU instances will go into RECOVER stage, then 
>> >> test
>> >> +     * kicking them out using migrate-pause.
>> >> +     */
>> >> +    wait_for_postcopy_status(from, "postcopy-recover");
>> >> +    wait_for_postcopy_status(to, "postcopy-recover");
>> >
>> > Is this wait out of place? I think we're trying to resume too fast after
>> > migrate_recover():
>> >
>> > # {
>> > #     "error": {
>> > #         "class": "GenericError",
>> > #         "desc": "Cannot resume if there is no paused migration"
>> > #     }
>> > # }
>> >
>> 
>> Ugh, sorry about the long lines:
>> 
>> {
>>     "error": {
>>         "class": "GenericError",
>>         "desc": "Cannot resume if there is no paused migration"
>>     }
>> }
>
> Sorry I didn't get you here.  Could you elaborate your question?
>

The test is sometimes failing with the above message.

But indeed my question doesn't make sense. I forgot migrate_recover
happens on the destination. Nevermind.

The bug is still present nonetheless. We're going into migrate_prepare
in some state other than POSTCOPY_PAUSED.