[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH qemu] timer/i8254: Fix one shot PIT mode
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [PATCH qemu] timer/i8254: Fix one shot PIT mode |
|
Date: |
Fri, 6 Oct 2023 01:19:00 -0400 |
On Fri, Oct 06, 2023 at 02:36:52AM +0000, Damien Zammit wrote:
> >From: Michael Tokarev <mjt@tls.msk.ru>
> >26.02.2023 04:58, Damien Zammit wrote:
> >> Currently, the one-shot (mode 1) PIT expires far too quickly,
> >> due to the output being set under the wrong logic.
> >> This change fixes the one-shot PIT mode to behave similarly to mode 0.
> >>
> >> TESTED: using the one-shot PIT mode to calibrate a local apic timer.
> >
> >Has this been forgotten, or is it not needed anymore?
>
> This is still required but nobody uses the
> PIT one-shot mode (probably because it *is* currently broken).
>
> Can it be merged?
>
> Thanks,
> Damien
OK, I tagged it. thanks!