[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 17/21] vfio/common: Move VFIO reset handler registration to a grou
|
From: |
Cédric Le Goater |
|
Subject: |
[PULL 17/21] vfio/common: Move VFIO reset handler registration to a group agnostic function |
|
Date: |
Fri, 6 Oct 2023 08:20:01 +0200 |
From: Zhenzhong Duan <zhenzhong.duan@intel.com>
Move the reset handler registration/unregistration to a place that is not
group specific. vfio_[get/put]_address_space are the best places for that
purpose.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Yi Liu <yi.l.liu@intel.com>
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
hw/vfio/common.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index
56cfe94d97779b539dbb15d88f2968c377d16bae..019da387d239cd005ab38577a68f35a013c98587
100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -1909,6 +1909,10 @@ static VFIOAddressSpace
*vfio_get_address_space(AddressSpace *as)
space->as = as;
QLIST_INIT(&space->containers);
+ if (QLIST_EMPTY(&vfio_address_spaces)) {
+ qemu_register_reset(vfio_reset_handler, NULL);
+ }
+
QLIST_INSERT_HEAD(&vfio_address_spaces, space, list);
return space;
@@ -1920,6 +1924,9 @@ static void vfio_put_address_space(VFIOAddressSpace
*space)
QLIST_REMOVE(space, list);
g_free(space);
}
+ if (QLIST_EMPTY(&vfio_address_spaces)) {
+ qemu_unregister_reset(vfio_reset_handler, NULL);
+ }
}
/*
@@ -2385,10 +2392,6 @@ static VFIOGroup *vfio_get_group(int groupid,
AddressSpace *as, Error **errp)
goto close_fd_exit;
}
- if (QLIST_EMPTY(&vfio_group_list)) {
- qemu_register_reset(vfio_reset_handler, NULL);
- }
-
QLIST_INSERT_HEAD(&vfio_group_list, group, next);
return group;
@@ -2417,10 +2420,6 @@ static void vfio_put_group(VFIOGroup *group)
trace_vfio_put_group(group->fd);
close(group->fd);
g_free(group);
-
- if (QLIST_EMPTY(&vfio_group_list)) {
- qemu_unregister_reset(vfio_reset_handler, NULL);
- }
}
struct vfio_device_info *vfio_get_device_info(int fd)
--
2.41.0
- [PULL 09/21] vfio/common: Move IOMMU agnostic helpers to a separate file, (continued)
- [PULL 09/21] vfio/common: Move IOMMU agnostic helpers to a separate file, Cédric Le Goater, 2023/10/06
- [PULL 10/21] vfio/common: Propagate KVM_SET_DEVICE_ATTR error if any, Cédric Le Goater, 2023/10/06
- [PULL 11/21] vfio/common: Introduce vfio_container_add|del_section_window(), Cédric Le Goater, 2023/10/06
- [PULL 12/21] vfio/common: Extract out vfio_kvm_device_[add/del]_fd, Cédric Le Goater, 2023/10/06
- [PULL 15/21] vfio/ap: Use vfio_[attach/detach]_device, Cédric Le Goater, 2023/10/06
- [PULL 14/21] vfio/platform: Use vfio_[attach/detach]_device, Cédric Le Goater, 2023/10/06
- [PULL 13/21] vfio/pci: Introduce vfio_[attach/detach]_device, Cédric Le Goater, 2023/10/06
- [PULL 18/21] vfio/common: Introduce a per container device list, Cédric Le Goater, 2023/10/06
- [PULL 16/21] vfio/ccw: Use vfio_[attach/detach]_device, Cédric Le Goater, 2023/10/06
- [PULL 21/21] vfio/common: Move legacy VFIO backend code into separate container.c, Cédric Le Goater, 2023/10/06
- [PULL 17/21] vfio/common: Move VFIO reset handler registration to a group agnostic function,
Cédric Le Goater <=
- [PULL 20/21] vfio/common: Introduce a global VFIODevice list, Cédric Le Goater, 2023/10/06
- [PULL 19/21] vfio/common: Store the parent container in VFIODevice, Cédric Le Goater, 2023/10/06
- Re: [PULL 00/21] vfio queue, Cédric Le Goater, 2023/10/06
- Re: [PULL 00/21] vfio queue, Eric Auger, 2023/10/06
- Re: [PULL 00/21] vfio queue, Eric Auger, 2023/10/06
- Re: [PULL 00/21] vfio queue, Eric Auger, 2023/10/06
- Re: [PULL 00/21] vfio queue, Cédric Le Goater, 2023/10/06
- Re: [PULL 00/21] vfio queue, Eric Auger, 2023/10/06
- Re: [PULL 00/21] vfio queue, Cédric Le Goater, 2023/10/07
- Re: [PULL 00/21] vfio queue, Michael Tokarev, 2023/10/07