Re: [PATCH 2/6] target/riscv: Use env_archcpu() in [check_]nanbox()

[Richard Henderson]

On 10/9/23 05:42, LIU Zhiwei wrote:
> On 2023/10/9 19:02, Philippe Mathieu-Daudé wrote:
> > When CPUArchState* is available (here CPURISCVState*), we
> > can use the fast env_archcpu() macro to get ArchCPU* (here
> > RISCVCPU*). The QOM cast RISCV_CPU() macro will be slower
> > when building with --enable-qom-cast-debug.
> >
> > Inspired-by: Richard W.M. Jones <rjones@redhat.com>
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
>
> By the way, does the community has the plan to support heterogeneous architecture cpus in 
> one soc?

Yes.

> If so, maybe we have to do this qom cast somewhere.

No, I don't think so.  Or at least not in these places.


r~