Re: [PATCH v2 6/9] tests/qtest/migration: Introduce find_common_machine_version

[Juan Quintela]

Fabiano Rosas <farosas@suse.de> wrote:
> When using two different QEMU binaries for migration testing, we'll
> need to find what is the machine version that will work with both
> binaries. Add a helper for that.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>

Reviewed-by: Juan Quintela <quintela@redhat.com>

As it should never fails.

> +    if (qtest_has_machine_with_env(var1, type2)) {
> +        return g_strdup(type2);
> +    }

But if it ever fails, printing here an error message with the contents
of mtype, var1 and var2 sounds like a good idea.

> +    g_assert_not_reached();