[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RESEND 3/7] migration/ram: Remove RAMState from xbzrle_cache_zero
|
From: |
Fabiano Rosas |
|
Subject: |
[PATCH RESEND 3/7] migration/ram: Remove RAMState from xbzrle_cache_zero_page |
|
Date: |
Wed, 11 Oct 2023 15:46:00 -0300 |
'rs' is not used in that function. It's a leftover from commit
9360447d34 ("ram: Use MigrationStats for statistics").
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
migration/ram.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 1cc14e543e..cd765212af 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -569,7 +569,6 @@ void mig_throttle_counter_reset(void)
/**
* xbzrle_cache_zero_page: insert a zero page in the XBZRLE cache
*
- * @rs: current RAM state
* @current_addr: address for the zero page
*
* Update the xbzrle cache to reflect a page that's been sent as all 0.
@@ -578,7 +577,7 @@ void mig_throttle_counter_reset(void)
* As a bonus, if the page wasn't in the cache it gets added so that
* when a small write is made into the 0'd page it gets XBZRLE sent.
*/
-static void xbzrle_cache_zero_page(RAMState *rs, ram_addr_t current_addr)
+static void xbzrle_cache_zero_page(ram_addr_t current_addr)
{
/* We don't care if this fails to allocate a new cache page
* as long as it updated an old one */
@@ -2144,7 +2143,7 @@ static int ram_save_target_page_legacy(RAMState *rs,
PageSearchStatus *pss)
*/
if (rs->xbzrle_started) {
XBZRLE_cache_lock();
- xbzrle_cache_zero_page(rs, block->offset + offset);
+ xbzrle_cache_zero_page(block->offset + offset);
XBZRLE_cache_unlock();
}
return res;
--
2.35.3
- [PATCH RESEND 0/7] migration pending patches, Fabiano Rosas, 2023/10/11
- [PATCH RESEND 3/7] migration/ram: Remove RAMState from xbzrle_cache_zero_page,
Fabiano Rosas <=
- [PATCH RESEND 4/7] migration/ram: Stop passing QEMUFile around in save_zero_page, Fabiano Rosas, 2023/10/11
- [PATCH RESEND 1/7] tests/qtest: migration-test: Add tests for file-based migration, Fabiano Rosas, 2023/10/11
- [PATCH RESEND 6/7] migration/ram: Merge save_zero_page functions, Fabiano Rosas, 2023/10/11
- [PATCH RESEND 5/7] migration/ram: Move xbzrle zero page handling into save_zero_page, Fabiano Rosas, 2023/10/11
- [PATCH RESEND 7/7] tests/qtest: Re-enable multifd cancel test, Fabiano Rosas, 2023/10/11
- [PATCH RESEND 2/7] migration/ram: Refactor precopy ram loading code, Fabiano Rosas, 2023/10/11