Re: [RFC/PATCH v0 08/12] gunyah: Specific device-tree location

[Philippe Mathieu-Daudé]

On 11/10/23 18:52, Srivatsa Vaddagiri wrote:
> Specify the location of device-tree and its size, as Gunyah requires the
> device-tree to be parsed before VM can begin its execution.
>
> Signed-off-by: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>
> ---
>   MAINTAINERS             |  1 +
>   hw/arm/virt.c           |  6 ++++++
>   include/sysemu/gunyah.h |  7 +++++++
>   target/arm/gunyah.c     | 45 +++++++++++++++++++++++++++++++++++++++++
>   target/arm/meson.build  |  4 ++++
>   5 files changed, 63 insertions(+)
>   create mode 100644 target/arm/gunyah.c


> diff --git a/include/sysemu/gunyah.h b/include/sysemu/gunyah.h
> index aded49cdf6..101e190619 100644
> --- a/include/sysemu/gunyah.h
> +++ b/include/sysemu/gunyah.h
> @@ -34,10 +34,17 @@ typedef struct GUNYAHState GUNYAHState;
>   DECLARE_INSTANCE_CHECKER(GUNYAHState, GUNYAH_STATE,
>                            TYPE_GUNYAH_ACCEL)
>   
> +int gunyah_arm_set_dtb(__u64 dtb_start, __u64 dtb_size);

By moving this declaration before the #ifdef ...

> +
>   #else   /* CONFIG_GUNYAH_IS_POSSIBLE */
>   
>   #define gunyah_enabled()    0
>   
> +static inline int gunyah_arm_set_dtb(__u64 dtb_start, __u64 dtb_size)
> +{
> +    return -1;
> +}

... you don't need this stub.

> +
>   #endif  /* CONFIG_GUNYAH_IS_POSSIBLE */
>   
>   #endif  /* QEMU_GUNYAH_H */