Re: [PATCH V5 1/9] accel/kvm: Extract common KVM vCPU {creation,parking} code

[Jonathan Cameron]

On Wed, 11 Oct 2023 20:43:47 +0100
Salil Mehta <salil.mehta@huawei.com> wrote:

> KVM vCPU creation is done once during the initialization of the VM when Qemu
> thread is spawned. This is common to all the architectures.
> 
> Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the
> corresponding KVM vCPU object in the Host KVM is not destroyed and its
> representative KVM vCPU object/context in Qemu is parked.
> 
> Refactor common logic so that some APIs could be reused by vCPU Hotplug code.

If you are respinning I'd also call out that you added some trace points.

> 
> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> Reviewed-by: Gavin Shan <gshan@redhat.com>
> Tested-by: Vishnu Pajjuri <vishnu@os.amperecomputing.com>
Otherwise LGTM as it's a straight forward refactor.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>