[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/7] tests/qtest: Fix npcm7xx_timer-test.c flaky test
From: |
Thomas Huth |
Subject: |
[PULL 3/7] tests/qtest: Fix npcm7xx_timer-test.c flaky test |
Date: |
Thu, 12 Oct 2023 18:51:04 +0200 |
From: Chris Rauer <crauer@google.com>
npcm7xx_timer-test occasionally fails due to the state of the timers
from the previous test iteration. Advancing the clock step after the
reset resolves this issue.
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1897
Signed-off-by: Chris Rauer <crauer@google.com>
Message-ID: <20230929000831.691559-1-crauer@google.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/npcm7xx_timer-test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/npcm7xx_timer-test.c b/tests/qtest/npcm7xx_timer-test.c
index 43711049ca..58f58c2f71 100644
--- a/tests/qtest/npcm7xx_timer-test.c
+++ b/tests/qtest/npcm7xx_timer-test.c
@@ -465,6 +465,7 @@ static void test_periodic_interrupt(gconstpointer test_data)
int i;
tim_reset(td);
+ clock_step_next();
tim_write_ticr(td, count);
tim_write_tcsr(td, CEN | IE | MODE_PERIODIC | PRESCALE(ps));
--
2.41.0
- [PULL 0/7] Misc patches, Thomas Huth, 2023/10/12
- [PULL 2/7] hw/rdma: Deprecate the pvrdma device and the rdma subsystem, Thomas Huth, 2023/10/12
- [PULL 4/7] hw/misc/i2c-echo: add copyright/license note, Thomas Huth, 2023/10/12
- [PULL 6/7] MAINTAINERS: Add include/sysemu/qtest.h to the qtest section, Thomas Huth, 2023/10/12
- [PULL 1/7] hw/pvrdma: Protect against buggy or malicious guest driver, Thomas Huth, 2023/10/12
- [PULL 3/7] tests/qtest: Fix npcm7xx_timer-test.c flaky test,
Thomas Huth <=
- [PULL 5/7] hw/misc/Kconfig: add switch for i2c-echo, Thomas Huth, 2023/10/12
- [PULL 7/7] gitlab-ci: Disable the riscv64-debian-cross-container by default, Thomas Huth, 2023/10/12
- Re: [PULL 0/7] Misc patches, Stefan Hajnoczi, 2023/10/16