Re: [PATCH v2 12/29] handler for reading registers added

[Alex Bennée]

Nicolas Eder <nicolas.eder@lauterbach.com> writes:

> From: neder <nicolas.eder@lauterbach.com>
>
> ---
>  mcdstub/internals.h          |  11 ++-
>  mcdstub/mcd_shared_defines.h |   7 ++
>  mcdstub/mcdstub.c            | 129 +++++++++++++++++++++++++++++++++++
>  target/arm/mcdstub.c         |  75 ++++++++++++++++++++
>  target/arm/mcdstub.h         |   7 ++

This isn't going to fly - we can't add a set of handlers for every
debugger to every architecture. You need to figure out a way to use the
existing gdb register stubs to fetch the data you need.

We've recently merged a bunch of cleanups to the gdbstub register
handling from Akihiko Odaki in preparation for using them for TCG
plugins. You should be able to make use of that work for mcdstub as
well.

>  5 files changed, 228 insertions(+), 1 deletion(-)
>  create mode 100644 target/arm/mcdstub.c
>  create mode 100644 target/arm/mcdstub.h
>
<snip>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro