[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 01/11] migration: RDMA is not compatible with anything else
|
From: |
Juan Quintela |
|
Subject: |
[PULL 01/11] migration: RDMA is not compatible with anything else |
|
Date: |
Wed, 18 Oct 2023 12:06:41 +0200 |
So give an error instead of just ignoring the other methods.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
Message-ID: <20230613145757.10131-4-quintela@redhat.com>
---
migration/migration.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index 6ba5e145ac..81862fcaa9 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -447,6 +447,18 @@ static void qemu_start_incoming_migration(const char *uri,
Error **errp)
socket_start_incoming_migration(p ? p : uri, errp);
#ifdef CONFIG_RDMA
} else if (strstart(uri, "rdma:", &p)) {
+ if (migrate_compress()) {
+ error_setg(errp, "RDMA and compression can't be used together");
+ return;
+ }
+ if (migrate_xbzrle()) {
+ error_setg(errp, "RDMA and XBZRLE can't be used together");
+ return;
+ }
+ if (migrate_multifd()) {
+ error_setg(errp, "RDMA and multifd can't be used together");
+ return;
+ }
rdma_start_incoming_migration(p, errp);
#endif
} else if (strstart(uri, "exec:", &p)) {
--
2.41.0
- [PULL 00/11] Migration 20231018 patches, Juan Quintela, 2023/10/18
- [PULL 02/11] migration: Move compression_counters cleanup ram-compress.c, Juan Quintela, 2023/10/18
- [PULL 01/11] migration: RDMA is not compatible with anything else,
Juan Quintela <=
- [PULL 04/11] migration: Create ram_compressed_pages(), Juan Quintela, 2023/10/18
- [PULL 07/11] migration: Use "i" as an for index in ram-compress.c, Juan Quintela, 2023/10/18
- [PULL 11/11] migration: save_zero_page() can take block through pss, Juan Quintela, 2023/10/18
- [PULL 09/11] migration: save_compress_page() can take block through pss, Juan Quintela, 2023/10/18
- [PULL 05/11] migration: Move update_compress_threads_counts() to ram-compress.c, Juan Quintela, 2023/10/18
- [PULL 10/11] migration: control_save_page() can take block through pss, Juan Quintela, 2023/10/18
- [PULL 06/11] migration: Simplify decompress_data_with_multi_threads(), Juan Quintela, 2023/10/18
- [PULL 08/11] migration: Print block status when needed, Juan Quintela, 2023/10/18
- [PULL 03/11] migration: Create populate_compress(), Juan Quintela, 2023/10/18
- Re: [PULL 00/11] Migration 20231018 patches, Stefan Hajnoczi, 2023/10/20