[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/11] migration: Create populate_compress()
|
From: |
Juan Quintela |
|
Subject: |
[PULL 03/11] migration: Create populate_compress() |
|
Date: |
Wed, 18 Oct 2023 12:06:43 +0200 |
So we don't have to access compression_counters from outside
ram-compress.c.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
Message-ID: <20230613145757.10131-7-quintela@redhat.com>
---
migration/ram-compress.h | 3 +++
migration/migration.c | 11 +----------
migration/ram-compress.c | 13 +++++++++++++
3 files changed, 17 insertions(+), 10 deletions(-)
diff --git a/migration/ram-compress.h b/migration/ram-compress.h
index 6f7fe2f472..43ff44c0ba 100644
--- a/migration/ram-compress.h
+++ b/migration/ram-compress.h
@@ -30,6 +30,7 @@
#define QEMU_MIGRATION_COMPRESS_H
#include "qemu-file.h"
+#include "qapi/qapi-types-migration.h"
enum CompressResult {
RES_NONE = 0,
@@ -67,4 +68,6 @@ void compress_threads_load_cleanup(void);
int compress_threads_load_setup(QEMUFile *f);
void decompress_data_with_multi_threads(QEMUFile *f, void *host, int len);
+void populate_compress(MigrationInfo *info);
+
#endif
diff --git a/migration/migration.c b/migration/migration.c
index a808abd294..05c0b801ba 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -974,16 +974,7 @@ static void populate_ram_info(MigrationInfo *info,
MigrationState *s)
info->xbzrle_cache->overflow = xbzrle_counters.overflow;
}
- if (migrate_compress()) {
- info->compression = g_malloc0(sizeof(*info->compression));
- info->compression->pages = compression_counters.pages;
- info->compression->busy = compression_counters.busy;
- info->compression->busy_rate = compression_counters.busy_rate;
- info->compression->compressed_size =
- compression_counters.compressed_size;
- info->compression->compression_rate =
- compression_counters.compression_rate;
- }
+ populate_compress(info);
if (cpu_throttle_active()) {
info->has_cpu_throttle_percentage = true;
diff --git a/migration/ram-compress.c b/migration/ram-compress.c
index a0f6a56470..bbf78a02d4 100644
--- a/migration/ram-compress.c
+++ b/migration/ram-compress.c
@@ -488,3 +488,16 @@ void decompress_data_with_multi_threads(QEMUFile *f, void
*host, int len)
}
}
}
+
+void populate_compress(MigrationInfo *info)
+{
+ if (!migrate_compress()) {
+ return;
+ }
+ info->compression = g_malloc0(sizeof(*info->compression));
+ info->compression->pages = compression_counters.pages;
+ info->compression->busy = compression_counters.busy;
+ info->compression->busy_rate = compression_counters.busy_rate;
+ info->compression->compressed_size = compression_counters.compressed_size;
+ info->compression->compression_rate =
compression_counters.compression_rate;
+}
--
2.41.0
- [PULL 02/11] migration: Move compression_counters cleanup ram-compress.c, (continued)
- [PULL 02/11] migration: Move compression_counters cleanup ram-compress.c, Juan Quintela, 2023/10/18
- [PULL 01/11] migration: RDMA is not compatible with anything else, Juan Quintela, 2023/10/18
- [PULL 04/11] migration: Create ram_compressed_pages(), Juan Quintela, 2023/10/18
- [PULL 07/11] migration: Use "i" as an for index in ram-compress.c, Juan Quintela, 2023/10/18
- [PULL 11/11] migration: save_zero_page() can take block through pss, Juan Quintela, 2023/10/18
- [PULL 09/11] migration: save_compress_page() can take block through pss, Juan Quintela, 2023/10/18
- [PULL 05/11] migration: Move update_compress_threads_counts() to ram-compress.c, Juan Quintela, 2023/10/18
- [PULL 10/11] migration: control_save_page() can take block through pss, Juan Quintela, 2023/10/18
- [PULL 06/11] migration: Simplify decompress_data_with_multi_threads(), Juan Quintela, 2023/10/18
- [PULL 08/11] migration: Print block status when needed, Juan Quintela, 2023/10/18
- [PULL 03/11] migration: Create populate_compress(),
Juan Quintela <=
- Re: [PULL 00/11] Migration 20231018 patches, Stefan Hajnoczi, 2023/10/20