Re: [PATCH v1 3/3] target/loongarch: Implement query-cpu-model-expansion

[Markus Armbruster]

Song Gao <gaosong@loongson.cn> writes:

> Add support for the query-cpu-model-expansion QMP command to LoongArch.
> We only support query the 'max' cpu features.
>
>   e.g
>     start with '-cpu max,lasx=off'
>
>     (QEMU) query-cpu-model-expansion type=static  model={"name":"max"}
>     {"return": {"model": {"name": "max", "props": {"lasx": false, "lsx": 
> true}}}}

Suggest to show what happens when you try to query something else.

> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
>  qapi/machine-target.json              |  6 ++-
>  target/loongarch/loongarch-qmp-cmds.c | 64 +++++++++++++++++++++++++++
>  2 files changed, 68 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/machine-target.json b/qapi/machine-target.json
> index f0a6b72414..752b18cced 100644
> --- a/qapi/machine-target.json
> +++ b/qapi/machine-target.json
> @@ -228,7 +228,8 @@
>    'data': { 'model': 'CpuModelInfo' },
>    'if': { 'any': [ 'TARGET_S390X',
>                     'TARGET_I386',
> -                   'TARGET_ARM' ] } }
> +                   'TARGET_ARM',
> +                   'TARGET_LOONGARCH64' ] } }
>  
>  ##
>  # @query-cpu-model-expansion:
> @@ -273,7 +274,8 @@
>    'returns': 'CpuModelExpansionInfo',
>    'if': { 'any': [ 'TARGET_S390X',
>                     'TARGET_I386',
> -                   'TARGET_ARM' ] } }
> +                   'TARGET_ARM',
> +                   'TARGET_LOONGARCH64' ] } }
>  
>  ##
>  # @CpuDefinitionInfo:

QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>

[...]