[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/11] scripts: qapi: black format main.py
|
From: |
Victor Toso |
|
Subject: |
Re: [PATCH v2 02/11] scripts: qapi: black format main.py |
|
Date: |
Wed, 18 Oct 2023 17:23:27 +0200 |
On Wed, Oct 18, 2023 at 01:00:07PM +0200, Markus Armbruster wrote:
> Victor Toso <victortoso@redhat.com> writes:
>
> > flake8 complained:
> > ./main.py:60:1: E302 expected 2 blank lines, found 1
> >
> > Which is simple enough. My vim has black [0] enabled by default, so it
> > did some extra formatting. I'm proposing to follow it.
> >
> > [0] https://black.readthedocs.io/en/stable/
> >
> > Signed-off-by: Victor Toso <victortoso@redhat.com>
> > ---
> > scripts/qapi/main.py | 76 ++++++++++++++++++++++++++++----------------
> > 1 file changed, 48 insertions(+), 28 deletions(-)
>
> Is this all black hates about scripts/qapi/?
No, just scripts/qapi/main.py.
> Did you configure it in any way, and if yes, how?
Only to reduce line length to 79.
I can do a separate series for this, if the idea is accepted.
Cheers,
Victor
signature.asc
Description: PGP signature
- [PATCH v2 00/11] qapi-go: add generator for Golang interface, Victor Toso, 2023/10/16
- [PATCH v2 01/11] qapi: re-establish linting baseline, Victor Toso, 2023/10/16
- [PATCH v2 04/11] qapi: golang: Generate qapi's alternate types in Go, Victor Toso, 2023/10/16
- [PATCH v2 03/11] qapi: golang: Generate qapi's enum types in Go, Victor Toso, 2023/10/16
- [PATCH v2 05/11] qapi: golang: Generate qapi's struct types in Go, Victor Toso, 2023/10/16
- [PATCH v2 02/11] scripts: qapi: black format main.py, Victor Toso, 2023/10/16
[PATCH v2 08/11] qapi: golang: Generate qapi's event types in Go, Victor Toso, 2023/10/16
[PATCH v2 07/11] qapi: golang: Generate qapi's union types in Go, Victor Toso, 2023/10/16
[PATCH v2 09/11] qapi: golang: Generate qapi's command types in Go, Victor Toso, 2023/10/16
[PATCH v2 10/11] qapi: golang: Add CommandResult type to Go, Victor Toso, 2023/10/16
[PATCH v2 11/11] docs: add notes on Golang code generator, Victor Toso, 2023/10/16