qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 09/12] tests/qtest/migration: Set q35 as the default machi


From: Thomas Huth
Subject: Re: [PATCH v4 09/12] tests/qtest/migration: Set q35 as the default machine for x86_86
Date: Thu, 19 Oct 2023 08:28:59 +0200
User-agent: Mozilla Thunderbird

On 18/10/2023 21.27, Fabiano Rosas wrote:
Change the x86_64 to use the q35 machines in tests from now on. Keep
testing the pc macine on 32bit.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
this could affect bisecting, so I put it in separate patch to be
easier to revert
---
  tests/qtest/migration-test.c | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index b45a389de8..b718634b1c 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -756,7 +756,12 @@ static int test_migrate_start(QTestState **from, 
QTestState **to,
      got_dst_resume = false;
      if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
          memory_size = "150M";
-        machine_alias = "pc";
+
+        if (g_str_equal(arch, "i386")) {
+            machine_alias = "pc";
+        } else {
+            machine_alias = "q35";
+        }
          arch_opts = g_strdup_printf(
              "-drive if=none,id=d0,file=%s,format=raw "
              "-device ide-hd,drive=d0,secs=1,cyls=1,heads=1", bootpath);

Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]