qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] qapi/migration: Introduce compress-with-iaa migration pa


From: Juan Quintela
Subject: Re: [PATCH 2/5] qapi/migration: Introduce compress-with-iaa migration parameter
Date: Thu, 19 Oct 2023 13:15:34 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux)

Yuan Liu <yuan1.liu@intel.com> wrote:
> Introduce the compress-with-iaa=on/off option to enable or disable live
> migration data (de)compression with the In-Memory Analytics Accelerator
> (IAA).
>
> The data (de)compression with IAA feature is based on the migration
> compression capability, which is enabled by setting
> migrate_set_capability compress on. If the migration compression
> capability is enabled and the IAA compression parameter is set, IAA will
> be used instead of CPU for data (de)compression.
>
> Signed-off-by: Yuan Liu <yuan1.liu@intel.com>
> Reviewed-by: Nanhai Zou <nanhai.zou@intel.com>

> @@ -724,6 +726,13 @@ int migrate_compress_threads(void)
>      return s->parameters.compress_threads;
>  }
>  
> +bool migrate_compress_with_iaa(void)
> +{
> +    MigrationState *s = migrate_get_current();
> +
> +    return s->parameters.compress_with_iaa;
> +}
> +

This should be in migration/options.c



> @@ -77,6 +77,7 @@ uint8_t migrate_cpu_throttle_increment(void);
>  uint8_t migrate_cpu_throttle_initial(void);
>  bool migrate_cpu_throttle_tailslow(void);
>  int migrate_decompress_threads(void);
> +bool migrate_compress_with_iaa(void);
>  uint64_t migrate_downtime_limit(void);
>  uint8_t migrate_max_cpu_throttle(void);
>  uint64_t migrate_max_bandwidth(void);

This list of functions is sorted.  The same in the migration/options.c.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]