[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 6/6] hw/m68k/virt: Do not open-code sysbus_create_simple()
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
[PATCH 6/6] hw/m68k/virt: Do not open-code sysbus_create_simple() |
|
Date: |
Fri, 20 Oct 2023 17:06:26 +0200 |
Mechanical change using the following coccinelle script:
@@
identifier dev;
expression qom_type;
expression addr;
expression irq;
@@
- dev = qdev_new(qom_type);
- sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
- sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, addr);
- sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, irq);
+ dev = sysbus_create_simple(qom_type, addr, irq);
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/m68k/virt.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/hw/m68k/virt.c b/hw/m68k/virt.c
index da35e74bd9..31038b8bb0 100644
--- a/hw/m68k/virt.c
+++ b/hw/m68k/virt.c
@@ -201,11 +201,8 @@ static void virt_init(MachineState *machine)
sysbus_connect_irq(sysbus, 0, PIC_GPIO(VIRT_GF_TTY_IRQ_BASE));
/* virt controller */
- dev = qdev_new(TYPE_VIRT_CTRL);
- sysbus = SYS_BUS_DEVICE(dev);
- sysbus_realize_and_unref(sysbus, &error_fatal);
- sysbus_mmio_map(sysbus, 0, VIRT_CTRL_MMIO_BASE);
- sysbus_connect_irq(sysbus, 0, PIC_GPIO(VIRT_CTRL_IRQ_BASE));
+ dev = sysbus_create_simple(TYPE_VIRT_CTRL, VIRT_CTRL_MMIO_BASE,
+ PIC_GPIO(VIRT_CTRL_IRQ_BASE));
/* virtio-mmio */
io_base = VIRT_VIRTIO_MMIO_BASE;
--
2.41.0
- [PATCH 1/6] hw/m68k/irqc: Pass CPU using QOM link property, (continued)
- [PATCH 1/6] hw/m68k/irqc: Pass CPU using QOM link property, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 2/6] hw/m68k/mcf5206: Pass CPU using QOM link property, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 3/6] hw/m68k/mcf_intc: Expose MMIO region via SysBus API, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 4/6] hw/m68k/mcf_intc: Pass CPU using QOM link property, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 5/6] hw/m68k/next-cube: Do not open-code sysbus_create_simple(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 6/6] hw/m68k/virt: Do not open-code sysbus_create_simple(),
Philippe Mathieu-Daudé <=
- Re: [PATCH 0/6] hw/m68k: Strengthen QOM/SysBus API uses, Richard Henderson, 2023/10/21