qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 6/6] hw/m68k/virt: Do not open-code sysbus_create_simple()


From: Thomas Huth
Subject: Re: [PATCH 6/6] hw/m68k/virt: Do not open-code sysbus_create_simple()
Date: Sun, 22 Oct 2023 11:43:23 +0200

Am Fri, 20 Oct 2023 17:06:26 +0200
schrieb Philippe Mathieu-Daudé <philmd@linaro.org>:

> Mechanical change using the following coccinelle script:
> 
>   @@
>   identifier dev;
>   expression qom_type;
>   expression addr;
>   expression irq;
>   @@
>   -    dev = qdev_new(qom_type);
>   -    sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
>   -    sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, addr);
>   -    sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, irq);
>   +    dev = sysbus_create_simple(qom_type, addr, irq);
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---

Reviewed-by: Thomas Huth <huth@tuxfamily.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]