Re: [PATCH V1 3/4] cpr: relax some blockers

[Peter Xu]

On Fri, Oct 20, 2023 at 11:38:55AM +0200, Juan Quintela wrote:
> Steve Sistare <steven.sistare@oracle.com> wrote:
> > Some devices block migration because they rely on local state that
> > is not migrated to the target host, such as for local filesystems.
> > These need not block cpr, which will restart qemu on the same host.
> > Narrow the scope of these blockers so they only apply to normal mode.
> > They will not block cpr modes when they are added in subsequent patches.
> >
> > No functional change until a new mode is added.
> >
> > Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
> 
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> 
> They are all basically block devices support, would be great to have a
> comment from someone from the block layer.

There're also non-block ones like vhost/9pfs/..

I agree with Daniel that we should split and allow module maintainers to
review.  Maybe we can unify changes of the same module into one patch.
Even if so, some comments for each site on explaining why local migration
can skip the blocker would be greatly helpful.

Thanks,

-- 
Peter Xu