[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v15 01/14] migration: New QAPI type 'MigrateAddress'
|
From: |
Fabiano Rosas |
|
Subject: |
[PATCH v15 01/14] migration: New QAPI type 'MigrateAddress' |
|
Date: |
Mon, 23 Oct 2023 15:20:40 -0300 |
From: Het Gala <het.gala@nutanix.com>
This patch introduces well defined MigrateAddress struct
and its related child objects.
The existing argument of 'migrate' and 'migrate-incoming' QAPI
- 'uri' is of type string. The current implementation follows
double encoding scheme for fetching migration parameters like
'uri' and this is not an ideal design.
Motive for intoducing struct level design is to prevent double
encoding of QAPI arguments, as Qemu should be able to directly
use the QAPI arguments without any level of encoding.
Note: this commit only adds the type, and actual uses comes
in later commits.
Suggested-by: Aravind Retnakaran <aravind.retnakaran@nutanix.com>
Signed-off-by: Het Gala <het.gala@nutanix.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Acked-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
qapi/migration.json | 41 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/qapi/migration.json b/qapi/migration.json
index db3df12d6c..c352c7ac52 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1508,6 +1508,47 @@
##
{ 'command': 'migrate-continue', 'data': {'state': 'MigrationStatus'} }
+##
+# @MigrationAddressType:
+#
+# The migration stream transport mechanisms.
+#
+# @socket: Migrate via socket.
+#
+# @exec: Direct the migration stream to another process.
+#
+# @rdma: Migrate via RDMA.
+#
+# Since 8.2
+##
+{ 'enum': 'MigrationAddressType',
+ 'data': ['socket', 'exec', 'rdma'] }
+
+##
+# @MigrationExecCommand:
+#
+# @args: command (list head) and arguments to execute.
+#
+# Since 8.2
+##
+{ 'struct': 'MigrationExecCommand',
+ 'data': {'args': [ 'str' ] } }
+
+##
+# @MigrationAddress:
+#
+# Migration endpoint configuration.
+#
+# Since 8.2
+##
+{ 'union': 'MigrationAddress',
+ 'base': { 'transport' : 'MigrationAddressType'},
+ 'discriminator': 'transport',
+ 'data': {
+ 'socket': 'SocketAddress',
+ 'exec': 'MigrationExecCommand',
+ 'rdma': 'InetSocketAddress' } }
+
##
# @migrate:
#
--
2.35.3
- [PATCH v15 00/14] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration, Fabiano Rosas, 2023/10/23
- [PATCH v15 01/14] migration: New QAPI type 'MigrateAddress',
Fabiano Rosas <=
- [PATCH v15 02/14] fixup! migration: New QAPI type 'MigrateAddress', Fabiano Rosas, 2023/10/23
- [PATCH v15 03/14] migration: convert migration 'uri' into 'MigrateAddress', Fabiano Rosas, 2023/10/23
- [PATCH v15 04/14] fixup! migration: convert migration 'uri' into 'MigrateAddress', Fabiano Rosas, 2023/10/23
- [PATCH v15 05/14] migration: convert socket backend to accept MigrateAddress, Fabiano Rosas, 2023/10/23
- [PATCH v15 06/14] migration: convert rdma backend to accept MigrateAddress, Fabiano Rosas, 2023/10/23