[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/9] migration: check required entries are loaded, once
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH v2 6/9] migration: check required entries are loaded, once |
|
Date: |
Tue, 24 Oct 2023 12:44:12 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) |
marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
> @@ -2541,6 +2572,11 @@ qemu_loadvm_section_start_full(QEMUFile *f,
> MigrationIncomingState *mis)
> idstr, instance_id);
> return -EINVAL;
> }
> + if (se->visited) {
> + error_report("error while loading state for instance 0x%"PRIx32" of"
> + " device '%s'", instance_id, idstr);
> + return -EINVAL;
> + }
When this is a subsection (always) It would be a good idea to know what
section we are talking about. but not sure how easy is to get that information.
Later, Juan.
- [PATCH v2 0/9] RFC: migration: check required entries and sections are loaded, marcandre . lureau, 2023/10/24
- [PATCH v2 1/9] block/fdc: 'phase' is not needed on load, marcandre . lureau, 2023/10/24
- [PATCH v2 2/9] virtio: make endian_needed() work during loading, marcandre . lureau, 2023/10/24
- [PATCH v2 4/9] migration: rename vmstate_save_needed->vmstate_section_needed, marcandre . lureau, 2023/10/24
- [PATCH v2 3/9] net/slirp: use different IDs for each instance, marcandre . lureau, 2023/10/24
- [PATCH v2 6/9] migration: check required entries are loaded, once, marcandre . lureau, 2023/10/24
- Re: [PATCH v2 6/9] migration: check required entries are loaded, once,
Juan Quintela <=
- [PATCH v2 5/9] migration: check required subsections are loaded, once, marcandre . lureau, 2023/10/24
- [PATCH v2 8/9] test-vmstate: add some subsection tests, marcandre . lureau, 2023/10/24
- [PATCH v2 7/9] migration: set file error on subsection loading, marcandre . lureau, 2023/10/24
- [PATCH v2 9/9] docs/migration: reflect the changes about needed subsections, marcandre . lureau, 2023/10/24