Re: [PATCH v2 0/3] vfio/pci: Fix buffer overrun when writing the VF token

[Peter Maydell]

On Thu, 26 Oct 2023 at 16:06, Konstantin Ryabitsev
<konstantin.ryabitsev@linux.dev> wrote:
>
> October 26, 2023 at 5:58 AM, "Cédric Le Goater" <clg@redhat.com> wrote:
> > >  Reviwed-by: Denis V. Lunev <den@openvz.org>
> > >
> >
> > I changed that to "Reviewed-by".
> >
> > Interesting to see that b4 was ok with this new tag.
>
> When we see an email address in the trailer contents, we don't check it 
> against a known-trailers list, because there are just too many things like 
> "Co-developed-by", "Reviewed-and-acked-by", etc. We could add some kind of 
> logic to break these apart and compare individual parts to a list of known 
> person-trailers (e.g. ["co", "reviewed", "developed", "and", "by", ...]), but 
> we currently don't, which is why typos like this one sneak through.

>From the QEMU development perspective, I would be mildly in favour
of having checkpatch at least warn about unusual trailers, because
I don't think the profusion of oddball stuff is actually helpful,
and nudging towards standardization and guarding against typos in
the tag string would be better (eg if you want to do both a review
and an ack, provide both tags, not an -and- tag that no tooling
that might be asking "did this get review?" will be looking for).
But I don't care enough to have actually looked at getting our
checkpatch to do this :-)

-- PMM