[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 05/12] hw/arm/sbsa-ref: Use qdev_prop_set_array()
|
From: |
Kevin Wolf |
|
Subject: |
[PATCH v2 05/12] hw/arm/sbsa-ref: Use qdev_prop_set_array() |
|
Date: |
Mon, 30 Oct 2023 15:26:51 +0100 |
Instead of manually setting "foo-len" and "foo[i]" properties, build a
QList and use the new qdev_prop_set_array() helper to set the whole
array property with a single call.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/arm/sbsa-ref.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
index e8a82618f0..6cf913300d 100644
--- a/hw/arm/sbsa-ref.c
+++ b/hw/arm/sbsa-ref.c
@@ -48,6 +48,7 @@
#include "hw/char/pl011.h"
#include "hw/watchdog/sbsa_gwdt.h"
#include "net/net.h"
+#include "qapi/qmp/qlist.h"
#include "qom/object.h"
#define RAMLIMIT_GB 8192
@@ -436,6 +437,7 @@ static void create_gic(SBSAMachineState *sms, MemoryRegion
*mem)
SysBusDevice *gicbusdev;
const char *gictype;
uint32_t redist0_capacity, redist0_count;
+ QList *redist_region_count;
int i;
gictype = gicv3_class_name();
@@ -454,8 +456,9 @@ static void create_gic(SBSAMachineState *sms, MemoryRegion
*mem)
sbsa_ref_memmap[SBSA_GIC_REDIST].size / GICV3_REDIST_SIZE;
redist0_count = MIN(smp_cpus, redist0_capacity);
- qdev_prop_set_uint32(sms->gic, "len-redist-region-count", 1);
- qdev_prop_set_uint32(sms->gic, "redist-region-count[0]", redist0_count);
+ redist_region_count = qlist_new();
+ qlist_append_int(redist_region_count, redist0_count);
+ qdev_prop_set_array(sms->gic, "redist-region-count", redist_region_count);
object_property_set_link(OBJECT(sms->gic), "sysmem",
OBJECT(mem), &error_fatal);
--
2.41.0
- [PATCH v2 00/12] qdev: Make array properties user accessible again, Kevin Wolf, 2023/10/30
- [PATCH v2 01/12] qdev: Add qdev_prop_set_array(), Kevin Wolf, 2023/10/30
- [PATCH v2 04/12] hw/arm/mps2: Use qdev_prop_set_array(), Kevin Wolf, 2023/10/30
- [PATCH v2 03/12] hw/arm/mps2-tz: Use qdev_prop_set_array(), Kevin Wolf, 2023/10/30
- [PATCH v2 02/12] hw/i386/pc: Use qdev_prop_set_array(), Kevin Wolf, 2023/10/30
- [PATCH v2 07/12] hw/arm/virt: Use qdev_prop_set_array(), Kevin Wolf, 2023/10/30
- [PATCH v2 10/12] qom: Add object_property_set_default_list(), Kevin Wolf, 2023/10/30
- [PATCH v2 11/12] qdev: Make netdev properties work as list elements, Kevin Wolf, 2023/10/30
- [PATCH v2 09/12] hw/rx/rx62n: Use qdev_prop_set_array(), Kevin Wolf, 2023/10/30
- [PATCH v2 05/12] hw/arm/sbsa-ref: Use qdev_prop_set_array(),
Kevin Wolf <=
- [PATCH v2 12/12] qdev: Rework array properties based on list visitor, Kevin Wolf, 2023/10/30
- [PATCH v2 06/12] hw/arm/vexpress: Use qdev_prop_set_array(), Kevin Wolf, 2023/10/30
- [PATCH v2 08/12] hw/arm/xlnx-versal: Use qdev_prop_set_array(), Kevin Wolf, 2023/10/30