Re: [PATCH v6 13/21] virtio-net: Always set populate_hash

[Akihiko Odaki]

On 2023/10/31 4:02, Zhang, Chen wrote:
> > -----Original Message-----
> > From: qemu-devel-bounces+chen.zhang=intel.com@nongnu.org <qemu-
> > devel-bounces+chen.zhang=intel.com@nongnu.org> On Behalf Of Akihiko
> > Odaki
> > Sent: Monday, October 30, 2023 1:13 PM
> > Cc: qemu-devel@nongnu.org; Yuri Benditovich
> > <yuri.benditovich@daynix.com>; Andrew Melnychenko
> > <andrew@daynix.com>; Michael S . Tsirkin <mst@redhat.com>; Jason Wang
> > <jasowang@redhat.com>; Akihiko Odaki <akihiko.odaki@daynix.com>
> > Subject: [PATCH v6 13/21] virtio-net: Always set populate_hash
> >
> > The member is not cleared during reset so may have a stale value.
>
> /docs/devel/ebpf_rss.rst:
> populate_hash - for now, not used. eBPF RSS doesn't support hash reporting.
>
> We need update docs?
> And why not clear it in virtio_net_reset function?

Certainly the documentation needs to be updated.
Either of clearing it in virtio_net_reset() or 
virtio_net_set_mrg_rx_bufs() is fine.

Regards,
Akihiko Odaki