[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] tests/qtest: check the return value
From: |
Zhang, Chen |
Subject: |
RE: [PATCH] tests/qtest: check the return value |
Date: |
Tue, 21 Nov 2023 07:09:35 +0000 |
> -----Original Message-----
> From: zhujun2 <zhujun2@cmss.chinamobile.com>
> Sent: Tuesday, November 21, 2023 2:17 PM
> To: Zhang, Chen <chen.zhang@intel.com>
> Cc: lvivier@redhat.com; pbonzini@redhat.com; qemu-devel@nongnu.org;
> thuth@redhat.com; zhujun2@cmss.chinamobile.com
> Subject: [PATCH] tests/qtest: check the return value
>
> These variables "ret" are never referenced in the code, that add check logic
> for the "ret"
>
Just tiny comments, please check the len before str, and add the V2 tag in mail
title next time.
After fix my comments and Thomas comments:
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Thanks
Chen
> Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
> ---
> tests/qtest/test-filter-mirror.c | 1 +
> tests/qtest/test-filter-redirector.c | 2 ++
> tests/qtest/virtio-net-test.c | 1 +
> 3 files changed, 4 insertions(+)
>
> diff --git a/tests/qtest/test-filter-mirror.c
> b/tests/qtest/test-filter-mirror.c
> index adeada3eb8..f3865f7519 100644
> --- a/tests/qtest/test-filter-mirror.c
> +++ b/tests/qtest/test-filter-mirror.c
> @@ -61,6 +61,7 @@ static void test_mirror(void)
> g_assert_cmpint(len, ==, sizeof(send_buf));
> recv_buf = g_malloc(len);
> ret = recv(recv_sock[0], recv_buf, len, 0);
> + g_assert_cmpint(ret, ==, len);
> g_assert_cmpstr(recv_buf, ==, send_buf);
>
> g_free(recv_buf);
> diff --git a/tests/qtest/test-filter-redirector.c b/tests/qtest/test-filter-
> redirector.c
> index e72e3b7873..a77d5fd8ec 100644
> --- a/tests/qtest/test-filter-redirector.c
> +++ b/tests/qtest/test-filter-redirector.c
> @@ -118,6 +118,7 @@ static void test_redirector_tx(void)
> g_assert_cmpint(len, ==, sizeof(send_buf));
> recv_buf = g_malloc(len);
> ret = recv(recv_sock, recv_buf, len, 0);
> + g_assert_cmpint(ret, ==, len);
> g_assert_cmpstr(recv_buf, ==, send_buf);
>
> g_free(recv_buf);
> @@ -185,6 +186,7 @@ static void test_redirector_rx(void)
> g_assert_cmpint(len, ==, sizeof(send_buf));
> recv_buf = g_malloc(len);
> ret = recv(backend_sock[0], recv_buf, len, 0);
> + g_assert_cmpint(ret, ==, len);
> g_assert_cmpstr(recv_buf, ==, send_buf);
>
> close(send_sock);
> diff --git a/tests/qtest/virtio-net-test.c b/tests/qtest/virtio-net-test.c
> index
> fab5dd8b05..b470d8c6e2 100644
> --- a/tests/qtest/virtio-net-test.c
> +++ b/tests/qtest/virtio-net-test.c
> @@ -92,6 +92,7 @@ static void tx_test(QVirtioDevice *dev,
>
> ret = recv(socket, buffer, len, 0);
> g_assert_cmpstr(buffer, ==, "TEST");
> + g_assert_cmpint(ret, ==, len);
Move it before g_assert_cmpstr().
> }
>
> static void rx_stop_cont_test(QVirtioDevice *dev,
> --
> 2.17.1
>
>