qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-9.0 00/21] target/arm: kvm cleanups


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH for-9.0 00/21] target/arm: kvm cleanups
Date: Thu, 23 Nov 2023 20:14:54 +0100
User-agent: Mozilla Thunderbird

On 23/11/23 18:40, Philippe Mathieu-Daudé wrote:
On 23/11/23 05:41, Richard Henderson wrote:
This is primarily concerned with merging kvm64.c with kvm.c
and then unexporting everything that is not required outside.


  target/arm/kvm_arm.h   |  203 ------

Unrelated to this series goal, but I notice half of the API takes
CPUState, the other ARMCPU...

$ git grep -F 'CPUState *' target/arm/kvm_arm.h | wc -l
       16
$ git grep -F 'ARMCPU *' target/arm/kvm_arm.h | wc -l
       14

Since this is ARM specific, I'd expect it always take ARMCPU, and
call the generic KVM API casting with the CPU() macro.

API clarification done here:
20231123183518.64569-1-philmd@linaro.org/">https://lore.kernel.org/qemu-devel/20231123183518.64569-1-philmd@linaro.org/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]