[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/6] Revert "tests/qtest/netdev-socket: Raise connection timeout
|
From: |
Daniel P . Berrangé |
|
Subject: |
[PATCH 3/6] Revert "tests/qtest/netdev-socket: Raise connection timeout to 120 seconds" |
|
Date: |
Thu, 4 Jan 2024 16:29:39 +0000 |
This reverts commit 0daaf2761f6d268ffaa2d01d450e202e127452b1.
The test was not timing out because of slow execution. It was
timing out due to a race condition leading to the client QEMU
attempting (and fatally failing) to connect before the server
QEMU was listening.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
tests/qtest/netdev-socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/netdev-socket.c b/tests/qtest/netdev-socket.c
index 7ba1eff120..3fc2ac26d0 100644
--- a/tests/qtest/netdev-socket.c
+++ b/tests/qtest/netdev-socket.c
@@ -16,7 +16,7 @@
#include "qapi/qobject-input-visitor.h"
#include "qapi/qapi-visit-sockets.h"
-#define CONNECTION_TIMEOUT 120
+#define CONNECTION_TIMEOUT 60
#define EXPECT_STATE(q, e, t) \
do { \
--
2.43.0
- [PATCH 0/6] net: fix non-deterministic failures of the 'netdev-socket' qtest, Daniel P . Berrangé, 2024/01/04
- [PATCH 1/6] Revert "netdev: set timeout depending on loadavg", Daniel P . Berrangé, 2024/01/04
- [PATCH 2/6] Revert "osdep: add getloadavg", Daniel P . Berrangé, 2024/01/04
- [PATCH 3/6] Revert "tests/qtest/netdev-socket: Raise connection timeout to 120 seconds",
Daniel P . Berrangé <=
- [PATCH 4/6] net: add explicit info about connecting/listening state, Daniel P . Berrangé, 2024/01/04
- [PATCH 6/6] qtest: ensure netdev-socket tests have non-overlapping names, Daniel P . Berrangé, 2024/01/04
- [PATCH 5/6] net: handle QIOTask completion to report useful error message, Daniel P . Berrangé, 2024/01/04
- Re: [PATCH 0/6] net: fix non-deterministic failures of the 'netdev-socket' qtest, Stefan Hajnoczi, 2024/01/04
- Re: [PATCH 0/6] net: fix non-deterministic failures of the 'netdev-socket' qtest, Daniel P . Berrangé, 2024/01/09