[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 5/6] target/riscv: Update address modify functions to take
|
From: |
Deepak Gupta |
|
Subject: |
Re: [PATCH v3 5/6] target/riscv: Update address modify functions to take into account pointer masking |
|
Date: |
Thu, 4 Jan 2024 17:02:33 -0800 |
> --- a/target/riscv/vector_helper.c
> +++ b/target/riscv/vector_helper.c
> @@ -94,6 +94,18 @@ static inline uint32_t vext_max_elems(uint32_t desc,
> uint32_t log2_esz)
>
> static inline target_ulong adjust_addr(CPURISCVState *env, target_ulong addr)
> {
> + RISCVPmPmm pmm = riscv_pm_get_pmm(env);
> + if (pmm == PMM_FIELD_DISABLED)
> + return addr;
> + int pmlen = riscv_pm_get_pmlen(pmm);
> + bool signext = !riscv_cpu_bare_mode(env);
> + addr = addr << pmlen;
> + /* sign/zero extend masked address by N-1 bit */
> + if (signext) {
> + addr = (target_long)addr >> pmlen;
These look like right shift operations and not sign extensions of N-1 bit
> + } else {
> + addr = addr >> pmlen;
Same here.
> + }
> return addr;
> }
>
> --
> 2.34.1
>
>
- Re: [PATCH v3 3/6] target/riscv: Add helper functions to calculate current number of masked bits for pointer masking, (continued)
[PATCH v3 4/6] target/riscv: Add pointer masking tb flags, Alexey Baturo, 2024/01/03
[PATCH v3 6/6] target/riscv: Enable updates for pointer masking variables and thus enable pointer masking extension, Alexey Baturo, 2024/01/03
[PATCH v3 5/6] target/riscv: Update address modify functions to take into account pointer masking, Alexey Baturo, 2024/01/03