[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/17] hw/vfio: fix iteration over global VFIODevice list
|
From: |
Cédric Le Goater |
|
Subject: |
[PULL 12/17] hw/vfio: fix iteration over global VFIODevice list |
|
Date: |
Mon, 8 Jan 2024 08:32:27 +0100 |
From: Volker Rümelin <vr_qemu@t-online.de>
Commit 3d779abafe ("vfio/common: Introduce a global VFIODevice list")
introduced a global VFIODevice list, but forgot to update the list
element field name when iterating over the new list. Change the code
to use the correct list element field.
Fixes: 3d779abafe ("vfio/common: Introduce a global VFIODevice list")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2061
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
---
hw/vfio/common.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index
0d4d8b8416c6a4770677e1ebe5e1fc7dbaaef004..0b3352f2a9d278f252a460e339732f1ccac0a96d
100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -73,7 +73,7 @@ bool vfio_mig_active(void)
return false;
}
- QLIST_FOREACH(vbasedev, &vfio_device_list, next) {
+ QLIST_FOREACH(vbasedev, &vfio_device_list, global_next) {
if (vbasedev->migration_blocker) {
return false;
}
@@ -94,7 +94,7 @@ static bool vfio_multiple_devices_migration_is_supported(void)
unsigned int device_num = 0;
bool all_support_p2p = true;
- QLIST_FOREACH(vbasedev, &vfio_device_list, next) {
+ QLIST_FOREACH(vbasedev, &vfio_device_list, global_next) {
if (vbasedev->migration) {
device_num++;
@@ -1366,13 +1366,13 @@ void vfio_reset_handler(void *opaque)
{
VFIODevice *vbasedev;
- QLIST_FOREACH(vbasedev, &vfio_device_list, next) {
+ QLIST_FOREACH(vbasedev, &vfio_device_list, global_next) {
if (vbasedev->dev->realized) {
vbasedev->ops->vfio_compute_needs_reset(vbasedev);
}
}
- QLIST_FOREACH(vbasedev, &vfio_device_list, next) {
+ QLIST_FOREACH(vbasedev, &vfio_device_list, global_next) {
if (vbasedev->dev->realized && vbasedev->needs_reset) {
vbasedev->ops->vfio_hot_reset_multi(vbasedev);
}
--
2.43.0
- [PULL 04/17] vfio/container: Introduce a VFIOIOMMU QOM interface, (continued)
- [PULL 04/17] vfio/container: Introduce a VFIOIOMMU QOM interface, Cédric Le Goater, 2024/01/08
- [PULL 06/17] vfio/container: Intoduce a new VFIOIOMMUClass::setup handler, Cédric Le Goater, 2024/01/08
- [PULL 07/17] vfio/spapr: Introduce a sPAPR VFIOIOMMU QOM interface, Cédric Le Goater, 2024/01/08
- [PULL 03/17] vfio/container: Initialize VFIOIOMMUOps under vfio_init_container(), Cédric Le Goater, 2024/01/08
- [PULL 01/17] vfio/spapr: Extend VFIOIOMMUOps with a release handler, Cédric Le Goater, 2024/01/08
- [PULL 05/17] vfio/container: Introduce a VFIOIOMMU legacy QOM interface, Cédric Le Goater, 2024/01/08
- [PULL 08/17] vfio/iommufd: Introduce a VFIOIOMMU iommufd QOM interface, Cédric Le Goater, 2024/01/08
- [PULL 09/17] vfio/spapr: Only compile sPAPR IOMMU support when needed, Cédric Le Goater, 2024/01/08
- [PULL 11/17] vfio/container: Replace basename with g_path_get_basename, Cédric Le Goater, 2024/01/08
- [PULL 10/17] vfio/iommufd: Remove CONFIG_IOMMUFD usage, Cédric Le Goater, 2024/01/08
- [PULL 12/17] hw/vfio: fix iteration over global VFIODevice list,
Cédric Le Goater <=
- [PULL 13/17] vfio/iommufd: Remove the use of stat() to check file existence, Cédric Le Goater, 2024/01/08
- [PULL 14/17] vfio/container: Rename vfio_init_container to vfio_set_iommu, Cédric Le Goater, 2024/01/08
- [PULL 15/17] vfio/migration: Add helper function to set state or reset device, Cédric Le Goater, 2024/01/08
- [PULL 16/17] backends/iommufd: Remove check on number of backend users, Cédric Le Goater, 2024/01/08
- [PULL 17/17] backends/iommufd: Remove mutex, Cédric Le Goater, 2024/01/08
- Re: [PULL 00/17] vfio queue, Peter Maydell, 2024/01/08