[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 05/17] Revert "tests/qtest/netdev-socket: Raise connection timeout
|
From: |
Thomas Huth |
|
Subject: |
[PULL 05/17] Revert "tests/qtest/netdev-socket: Raise connection timeout to 120 seconds" |
|
Date: |
Thu, 11 Jan 2024 18:00:34 +0100 |
From: Daniel P. Berrangé <berrange@redhat.com>
This reverts commit 0daaf2761f6d268ffaa2d01d450e202e127452b1.
The test was not timing out because of slow execution. It was
timing out due to a race condition leading to the client QEMU
attempting (and fatally failing) to connect before the server
QEMU was listening.
Signed-off-by: "Daniel P. Berrangé" <berrange@redhat.com>
Message-ID: <20240104162942.211458-4-berrange@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/netdev-socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/netdev-socket.c b/tests/qtest/netdev-socket.c
index 7ba1eff120..3fc2ac26d0 100644
--- a/tests/qtest/netdev-socket.c
+++ b/tests/qtest/netdev-socket.c
@@ -16,7 +16,7 @@
#include "qapi/qobject-input-visitor.h"
#include "qapi/qapi-visit-sockets.h"
-#define CONNECTION_TIMEOUT 120
+#define CONNECTION_TIMEOUT 60
#define EXPECT_STATE(q, e, t) \
do { \
--
2.43.0
- [PULL 00/17] Misc patches (qtests, s390x, m68k, gitlab-ci), Thomas Huth, 2024/01/11
- [PULL 01/17] q800: move dp8393x_prom memory region to Q800MachineState, Thomas Huth, 2024/01/11
- [PULL 03/17] Revert "netdev: set timeout depending on loadavg", Thomas Huth, 2024/01/11
- [PULL 06/17] net: add explicit info about connecting/listening state, Thomas Huth, 2024/01/11
- [PULL 02/17] qtest: use correct boolean type for failover property, Thomas Huth, 2024/01/11
- [PULL 07/17] net: handle QIOTask completion to report useful error message, Thomas Huth, 2024/01/11
- [PULL 05/17] Revert "tests/qtest/netdev-socket: Raise connection timeout to 120 seconds",
Thomas Huth <=
- [PULL 08/17] qtest: ensure netdev-socket tests have non-overlapping names, Thomas Huth, 2024/01/11
- [PULL 04/17] Revert "osdep: add getloadavg", Thomas Huth, 2024/01/11
- [PULL 10/17] gitlab: fix s390x tag for avocado-system-centos, Thomas Huth, 2024/01/11
- [PULL 11/17] target/s390x/kvm/pv: Provide some more useful information if decryption fails, Thomas Huth, 2024/01/11
- [PULL 09/17] tests/qtest/virtio-ccw: Fix device presence checking, Thomas Huth, 2024/01/11
- [PULL 13/17] hw/s390x/ccw: Replace dirname() with g_path_get_dirname(), Thomas Huth, 2024/01/11
- [PULL 15/17] target/s390x: Fix LAE setting a wrong access register, Thomas Huth, 2024/01/11
- [PULL 14/17] scripts/checkpatch: Support codespell checking, Thomas Huth, 2024/01/11
- [PULL 12/17] hw/s390x/ccw: Replace basename() with g_path_get_basename(), Thomas Huth, 2024/01/11
- [PULL 16/17] tests/tcg/s390x: Test LOAD ADDRESS EXTENDED, Thomas Huth, 2024/01/11