RE: [PATCH v2 7/9] Hexagon (target/hexagon) Make generators object oriented - gen_analyze_funcs

[Brian Cain]

> -----Original Message-----
> From: Taylor Simpson <ltaylorsimpson@gmail.com>
> Sent: Sunday, December 10, 2023 4:07 PM
> To: qemu-devel@nongnu.org
> Cc: Brian Cain <bcain@quicinc.com>; Matheus Bernardino (QUIC)
> <quic_mathbern@quicinc.com>; Sid Manning <sidneym@quicinc.com>; Marco
> Liebel (QUIC) <quic_mliebel@quicinc.com>; richard.henderson@linaro.org;
> philmd@linaro.org; ale@rev.ng; anjo@rev.ng; ltaylorsimpson@gmail.com
> Subject: [PATCH v2 7/9] Hexagon (target/hexagon) Make generators object
> oriented - gen_analyze_funcs
> 
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any links or attachments, and do not enable macros.
> 
> This patch conflicts with
> https://lists.gnu.org/archive/html/qemu-devel/2023-11/msg00729.html
> If that series goes in first, we'll rework this patch and vice versa.
> 
> Signed-off-by: Taylor Simpson <ltaylorsimpson@gmail.com>
> ---
>  target/hexagon/gen_analyze_funcs.py | 163 +---------------------------
>  target/hexagon/hex_common.py        | 151 ++++++++++++++++++++++++++
>  2 files changed, 157 insertions(+), 157 deletions(-)
> 
> diff --git a/target/hexagon/gen_analyze_funcs.py
> b/target/hexagon/gen_analyze_funcs.py
> index c3b521abef..a9af666cef 100755
> --- a/target/hexagon/gen_analyze_funcs.py
> +++ b/target/hexagon/gen_analyze_funcs.py
> @@ -23,162 +23,6 @@
>  import hex_common
> 
> 
> -##
> -## Helpers for gen_analyze_func
> -##
> -def is_predicated(tag):
> -    return "A_CONDEXEC" in hex_common.attribdict[tag]
> -
> -
> -def analyze_opn_old(f, tag, regtype, regid, regno):
> -    regN = f"{regtype}{regid}N"
> -    predicated = "true" if is_predicated(tag) else "false"
> -    if regtype == "R":
> -        if regid in {"ss", "tt"}:
> -            f.write(f"    const int {regN} = insn->regno[{regno}];\n")
> -            f.write(f"    ctx_log_reg_read_pair(ctx, {regN});\n")
> -        elif regid in {"dd", "ee", "xx", "yy"}:
> -            f.write(f"    const int {regN} = insn->regno[{regno}];\n")
> -            f.write(f"    ctx_log_reg_write_pair(ctx, {regN}, 
> {predicated});\n")
> -        elif regid in {"s", "t", "u", "v"}:
> -            f.write(f"    const int {regN} = insn->regno[{regno}];\n")
> -            f.write(f"    ctx_log_reg_read(ctx, {regN});\n")
> -        elif regid in {"d", "e", "x", "y"}:
> -            f.write(f"    const int {regN} = insn->regno[{regno}];\n")
> -            f.write(f"    ctx_log_reg_write(ctx, {regN}, {predicated});\n")
> -        else:
> -            hex_common.bad_register(regtype, regid)
> -    elif regtype == "P":
> -        if regid in {"s", "t", "u", "v"}:
> -            f.write(f"    const int {regN} = insn->regno[{regno}];\n")
> -            f.write(f"    ctx_log_pred_read(ctx, {regN});\n")
> -        elif regid in {"d", "e", "x"}:
> -            f.write(f"    const int {regN} = insn->regno[{regno}];\n")
> -            f.write(f"    ctx_log_pred_write(ctx, {regN});\n")
> -        else:
> -            hex_common.bad_register(regtype, regid)
> -    elif regtype == "C":
> -        if regid == "ss":
> -            f.write(
> -                f"    const int {regN} = insn->regno[{regno}] "
> -                "+ HEX_REG_SA0;\n"
> -            )
> -            f.write(f"    ctx_log_reg_read_pair(ctx, {regN});\n")
> -        elif regid == "dd":
> -            f.write(f"    const int {regN} = insn->regno[{regno}] " "+
> HEX_REG_SA0;\n")
> -            f.write(f"    ctx_log_reg_write_pair(ctx, {regN}, 
> {predicated});\n")
> -        elif regid == "s":
> -            f.write(
> -                f"    const int {regN} = insn->regno[{regno}] "
> -                "+ HEX_REG_SA0;\n"
> -            )
> -            f.write(f"    ctx_log_reg_read(ctx, {regN});\n")
> -        elif regid == "d":
> -            f.write(f"    const int {regN} = insn->regno[{regno}] " "+
> HEX_REG_SA0;\n")
> -            f.write(f"    ctx_log_reg_write(ctx, {regN}, {predicated});\n")
> -        else:
> -            hex_common.bad_register(regtype, regid)
> -    elif regtype == "M":
> -        if regid == "u":
> -            f.write(f"    const int {regN} = insn->regno[{regno}];\n")
> -            f.write(f"    ctx_log_reg_read(ctx, {regN});\n")
> -        else:
> -            hex_common.bad_register(regtype, regid)
> -    elif regtype == "V":
> -        newv = "EXT_DFL"
> -        if hex_common.is_new_result(tag):
> -            newv = "EXT_NEW"
> -        elif hex_common.is_tmp_result(tag):
> -            newv = "EXT_TMP"
> -        if regid in {"dd", "xx"}:
> -            f.write(f"    const int {regN} = insn->regno[{regno}];\n")
> -            f.write(
> -                f"    ctx_log_vreg_write_pair(ctx, {regN}, {newv}, " 
> f"{predicated});\n"
> -            )
> -        elif regid in {"uu", "vv"}:
> -            f.write(f"    const int {regN} = insn->regno[{regno}];\n")
> -            f.write(f"    ctx_log_vreg_read_pair(ctx, {regN});\n")
> -        elif regid in {"s", "u", "v", "w"}:
> -            f.write(f"    const int {regN} = insn->regno[{regno}];\n")
> -            f.write(f"    ctx_log_vreg_read(ctx, {regN});\n")
> -        elif regid in {"d", "x", "y"}:
> -            f.write(f"    const int {regN} = insn->regno[{regno}];\n")
> -            f.write(f"    ctx_log_vreg_write(ctx, {regN}, {newv}, "
> f"{predicated});\n")
> -        else:
> -            hex_common.bad_register(regtype, regid)
> -    elif regtype == "Q":
> -        if regid in {"d", "e", "x"}:
> -            f.write(f"    const int {regN} = insn->regno[{regno}];\n")
> -            f.write(f"    ctx_log_qreg_write(ctx, {regN});\n")
> -        elif regid in {"s", "t", "u", "v"}:
> -            f.write(f"    const int {regN} = insn->regno[{regno}];\n")
> -            f.write(f"    ctx_log_qreg_read(ctx, {regN});\n")
> -        else:
> -            hex_common.bad_register(regtype, regid)
> -    elif regtype == "G":
> -        if regid in {"dd"}:
> -            f.write(f"//    const int {regN} = insn->regno[{regno}];\n")
> -        elif regid in {"d"}:
> -            f.write(f"//    const int {regN} = insn->regno[{regno}];\n")
> -        elif regid in {"ss"}:
> -            f.write(f"//    const int {regN} = insn->regno[{regno}];\n")
> -        elif regid in {"s"}:
> -            f.write(f"//    const int {regN} = insn->regno[{regno}];\n")
> -        else:
> -            hex_common.bad_register(regtype, regid)
> -    elif regtype == "S":
> -        if regid in {"dd"}:
> -            f.write(f"//    const int {regN} = insn->regno[{regno}];\n")
> -        elif regid in {"d"}:
> -            f.write(f"//    const int {regN} = insn->regno[{regno}];\n")
> -        elif regid in {"ss"}:
> -            f.write(f"//    const int {regN} = insn->regno[{regno}];\n")
> -        elif regid in {"s"}:
> -            f.write(f"//    const int {regN} = insn->regno[{regno}];\n")
> -        else:
> -            hex_common.bad_register(regtype, regid)
> -    else:
> -        hex_common.bad_register(regtype, regid)
> -
> -
> -def analyze_opn_new(f, tag, regtype, regid, regno):
> -    regN = f"{regtype}{regid}N"
> -    if regtype == "N":
> -        if regid in {"s", "t"}:
> -            f.write(f"    const int {regN} = insn->regno[{regno}];\n")
> -            f.write(f"    ctx_log_reg_read(ctx, {regN});\n")
> -        else:
> -            hex_common.bad_register(regtype, regid)
> -    elif regtype == "P":
> -        if regid in {"t", "u", "v"}:
> -            f.write(f"    const int {regN} = insn->regno[{regno}];\n")
> -            f.write(f"    ctx_log_pred_read(ctx, {regN});\n")
> -        else:
> -            hex_common.bad_register(regtype, regid)
> -    elif regtype == "O":
> -        if regid == "s":
> -            f.write(f"    const int {regN} = insn->regno[{regno}];\n")
> -            f.write(f"    ctx_log_vreg_read(ctx, {regN});\n")
> -        else:
> -            hex_common.bad_register(regtype, regid)
> -    else:
> -        hex_common.bad_register(regtype, regid)
> -
> -
> -def analyze_opn(f, tag, regtype, regid, i):
> -    if hex_common.is_pair(regid):
> -        analyze_opn_old(f, tag, regtype, regid, i)
> -    elif hex_common.is_single(regid):
> -        if hex_common.is_old_val(regtype, regid, tag):
> -            analyze_opn_old(f, tag, regtype, regid, i)
> -        elif hex_common.is_new_val(regtype, regid, tag):
> -            analyze_opn_new(f, tag, regtype, regid, i)
> -        else:
> -            hex_common.bad_register(regtype, regid)
> -    else:
> -        hex_common.bad_register(regtype, regid)
> -
> -
>  ##
>  ## Generate the code to analyze the instruction
>  ##     For A2_add: Rd32=add(Rs32,Rt32), { RdV=RsV+RtV;}
> @@ -203,7 +47,11 @@ def gen_analyze_func(f, tag, regs, imms):
>      i = 0
>      ## Analyze all the registers
>      for regtype, regid in regs:
> -        analyze_opn(f, tag, regtype, regid, i)
> +        reg = hex_common.get_register(tag, regtype, regid)
> +        if reg.is_written():
> +            reg.analyze_write(f, tag, i)
> +        else:
> +            reg.analyze_read(f, i)
>          i += 1
> 
>      has_generated_helper = not hex_common.skip_qemu_helper(
> @@ -236,6 +84,7 @@ def main():
>      if is_idef_parser_enabled:
>          hex_common.read_idef_parser_enabled_file(sys.argv[5])
>      hex_common.calculate_attribs()
> +    hex_common.init_registers()
>      tagregs = hex_common.get_tagregs()
>      tagimms = hex_common.get_tagimms()
> 
> diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py
> index fc9ce4e2b0..4565dd1953 100755
> --- a/target/hexagon/hex_common.py
> +++ b/target/hexagon/hex_common.py
> @@ -486,6 +486,12 @@ def log_write(self, f, tag):
>          f.write(code_fmt(f"""\
>              gen_log_reg_write(ctx, {self.reg_num}, {self.reg_tcg()});
>          """))
> +    def analyze_write(self, f, tag, regno):
> +        self.decl_reg_num(f, regno)
> +        predicated = "true" if is_predicated(tag) else "false"
> +        f.write(code_fmt(f"""\
> +            ctx_log_reg_write(ctx, {self.reg_num}, {predicated});
> +        """))
> 
>  class GprSource(Register, Single, OldSource):
>      def decl_tcg(self, f, tag, regno):
> @@ -493,12 +499,22 @@ def decl_tcg(self, f, tag, regno):
>          f.write(code_fmt(f"""\
>              TCGv {self.reg_tcg()} = hex_gpr[{self.reg_num}];
>          """))
> +    def analyze_read(self, f, regno):
> +        self.decl_reg_num(f, regno)
> +        f.write(code_fmt(f"""\
> +            ctx_log_reg_read(ctx, {self.reg_num});
> +        """))
> 
>  class GprNewSource(Register, Single, NewSource):
>      def decl_tcg(self, f, tag, regno):
>          f.write(code_fmt(f"""\
>              TCGv {self.reg_tcg()} = get_result_gpr(ctx, 
> insn->regno[{regno}]);
>          """))
> +    def analyze_read(self, f, regno):
> +        self.decl_reg_num(f, regno)
> +        f.write(code_fmt(f"""\
> +            ctx_log_reg_read(ctx, {self.reg_num});
> +        """))
> 
>  class GprReadWrite(Register, Single, ReadWrite):
>      def decl_tcg(self, f, tag, regno):
> @@ -517,6 +533,12 @@ def log_write(self, f, tag):
>          f.write(code_fmt(f"""\
>              gen_log_reg_write(ctx, {self.reg_num}, {self.reg_tcg()});
>          """))
> +    def analyze_write(self, f, tag, regno):
> +        self.decl_reg_num(f, regno)
> +        predicated = "true" if is_predicated(tag) else "false"
> +        f.write(code_fmt(f"""\
> +            ctx_log_reg_write(ctx, {self.reg_num}, {predicated});
> +        """))
> 
>  class ControlDest(Register, Single, Dest):
>      def decl_reg_num(self, f, regno):
> @@ -532,6 +554,12 @@ def log_write(self, f, tag):
>          f.write(code_fmt(f"""\
>              gen_write_ctrl_reg(ctx, {self.reg_num}, {self.reg_tcg()});
>          """))
> +    def analyze_write(self, f, tag, regno):
> +        self.decl_reg_num(f, regno)
> +        predicated = "true" if is_predicated(tag) else "false"
> +        f.write(code_fmt(f"""\
> +            ctx_log_reg_write(ctx, {self.reg_num}, {predicated});
> +        """))
> 
>  class ControlSource(Register, Single, OldSource):
>      def decl_reg_num(self, f, regno):
> @@ -544,6 +572,11 @@ def decl_tcg(self, f, tag, regno):
>              TCGv {self.reg_tcg()} = tcg_temp_new();
>              gen_read_ctrl_reg(ctx, {self.reg_num}, {self.reg_tcg()});
>          """))
> +    def analyze_read(self, f, regno):
> +        self.decl_reg_num(f, regno)
> +        f.write(code_fmt(f"""\
> +            ctx_log_reg_read(ctx, {self.reg_num});
> +        """))
> 
>  class ModifierSource(Register, Single, OldSource):
>      def decl_reg_num(self, f, regno):
> @@ -560,6 +593,11 @@ def decl_tcg(self, f, tag, regno):
>      def idef_arg(self, declared):
>          declared.append(self.reg_tcg())
>          declared.append("CS")
> +    def analyze_read(self, f, regno):
> +        self.decl_reg_num(f, regno)
> +        f.write(code_fmt(f"""\
> +            ctx_log_reg_read(ctx, {self.reg_num});
> +        """))
> 
>  class PredDest(Register, Single, Dest):
>      def decl_tcg(self, f, tag, regno):
> @@ -571,6 +609,11 @@ def log_write(self, f, tag):
>          f.write(code_fmt(f"""\
>              gen_log_pred_write(ctx, {self.reg_num}, {self.reg_tcg()});
>          """))
> +    def analyze_write(self, f, tag, regno):
> +        self.decl_reg_num(f, regno)
> +        f.write(code_fmt(f"""\
> +            ctx_log_pred_write(ctx, {self.reg_num});
> +        """))
> 
>  class PredSource(Register, Single, OldSource):
>      def decl_tcg(self, f, tag, regno):
> @@ -578,12 +621,22 @@ def decl_tcg(self, f, tag, regno):
>          f.write(code_fmt(f"""\
>              TCGv {self.reg_tcg()} = hex_pred[{self.reg_num}];
>          """))
> +    def analyze_read(self, f, regno):
> +        self.decl_reg_num(f, regno)
> +        f.write(code_fmt(f"""\
> +            ctx_log_pred_read(ctx, {self.reg_num});
> +        """))
> 
>  class PredNewSource(Register, Single, NewSource):
>      def decl_tcg(self, f, tag, regno):
>          f.write(code_fmt(f"""\
>              TCGv {self.reg_tcg()} = get_result_pred(ctx, 
> insn->regno[{regno}]);
>          """))
> +    def analyze_read(self, f, regno):
> +        self.decl_reg_num(f, regno)
> +        f.write(code_fmt(f"""\
> +            ctx_log_pred_read(ctx, {self.reg_num});
> +        """))
> 
>  class PredReadWrite(Register, Single, ReadWrite):
>      def decl_tcg(self, f, tag, regno):
> @@ -596,6 +649,11 @@ def log_write(self, f, tag):
>          f.write(code_fmt(f"""\
>              gen_log_pred_write(ctx, {self.reg_num}, {self.reg_tcg()});
>          """))
> +    def analyze_write(self, f, tag, regno):
> +        self.decl_reg_num(f, regno)
> +        f.write(code_fmt(f"""\
> +            ctx_log_pred_write(ctx, {self.reg_num});
> +        """))
> 
>  class PairDest(Register, Pair, Dest):
>      def decl_tcg(self, f, tag, regno):
> @@ -608,6 +666,12 @@ def log_write(self, f, tag):
>          f.write(code_fmt(f"""\
>              gen_log_reg_write_pair(ctx, {self.reg_num}, {self.reg_tcg()});
>          """))
> +    def analyze_write(self, f, tag, regno):
> +        self.decl_reg_num(f, regno)
> +        predicated = "true" if is_predicated(tag) else "false"
> +        f.write(code_fmt(f"""\
> +            ctx_log_reg_write_pair(ctx, {self.reg_num}, {predicated});
> +        """))
> 
>  class PairSource(Register, Pair, OldSource):
>      def decl_tcg(self, f, tag, regno):
> @@ -618,6 +682,11 @@ def decl_tcg(self, f, tag, regno):
>                                      hex_gpr[{self.reg_num}],
>                                      hex_gpr[{self.reg_num} + 1]);
>          """))
> +    def analyze_read(self, f, regno):
> +        self.decl_reg_num(f, regno)
> +        f.write(code_fmt(f"""\
> +            ctx_log_reg_read_pair(ctx, {self.reg_num});
> +        """))
> 
>  class PairReadWrite(Register, Pair, ReadWrite):
>      def decl_tcg(self, f, tag, regno):
> @@ -633,6 +702,12 @@ def log_write(self, f, tag):
>          f.write(code_fmt(f"""\
>              gen_log_reg_write_pair(ctx, {self.reg_num}, {self.reg_tcg()});
>          """))
> +    def analyze_write(self, f, tag, regno):
> +        self.decl_reg_num(f, regno)
> +        predicated = "true" if is_predicated(tag) else "false"
> +        f.write(code_fmt(f"""\
> +            ctx_log_reg_write_pair(ctx, {self.reg_num}, {predicated});
> +        """))
> 
>  class ControlPairDest(Register, Pair, Dest):
>      def decl_reg_num(self, f, regno):
> @@ -649,6 +724,12 @@ def log_write(self, f, tag):
>          f.write(code_fmt(f"""\
>              gen_write_ctrl_reg_pair(ctx, {self.reg_num}, {self.reg_tcg()});
>          """))
> +    def analyze_write(self, f, tag, regno):
> +        self.decl_reg_num(f, regno)
> +        predicated = "true" if is_predicated(tag) else "false"
> +        f.write(code_fmt(f"""\
> +            ctx_log_reg_write_pair(ctx, {self.reg_num}, {predicated});
> +        """))
> 
>  class ControlPairSource(Register, Pair, OldSource):
>      def decl_reg_num(self, f, regno):
> @@ -661,6 +742,11 @@ def decl_tcg(self, f, tag, regno):
>              TCGv_i64 {self.reg_tcg()} = tcg_temp_new_i64();
>              gen_read_ctrl_reg_pair(ctx, {self.reg_num}, {self.reg_tcg()});
>          """))
> +    def analyze_read(self, f, regno):
> +        self.decl_reg_num(f, regno)
> +        f.write(code_fmt(f"""\
> +            ctx_log_reg_read_pair(ctx, {self.reg_num});
> +        """))
> 
>  class VRegDest(Register, Hvx, Dest):
>      def decl_tcg(self, f, tag, regno):
> @@ -680,6 +766,13 @@ def helper_hvx_desc(self, f):
>          f.write(code_fmt(f"""\
>              /* {self.reg_tcg()} is *(MMVector *)({self.helper_arg_name()}) */
>          """))
> +    def analyze_write(self, f, tag, regno):
> +        self.decl_reg_num(f, regno)
> +        newv = hvx_newv(tag)
> +        predicated = "true" if is_predicated(tag) else "false"
> +        f.write(code_fmt(f"""\
> +            ctx_log_vreg_write(ctx, {self.reg_num}, {newv}, {predicated});
> +        """))
> 
>  class VRegSource(Register, Hvx, OldSource):
>      def decl_tcg(self, f, tag, regno):
> @@ -696,6 +789,11 @@ def helper_hvx_desc(self, f):
>          f.write(code_fmt(f"""\
>              /* {self.reg_tcg()} is *(MMVector *)({self.helper_arg_name()}) */
>          """))
> +    def analyze_read(self, f, regno):
> +        self.decl_reg_num(f, regno)
> +        f.write(code_fmt(f"""\
> +            ctx_log_vreg_read(ctx, {self.reg_num});
> +        """))
> 
>  class VRegNewSource(Register, Hvx, NewSource):
>      def decl_tcg(self, f, tag, regno):
> @@ -709,6 +807,11 @@ def helper_hvx_desc(self, f):
>          f.write(code_fmt(f"""\
>              /* {self.reg_tcg()} is *(MMVector *)({self.helper_arg_name()}) */
>          """))
> +    def analyze_read(self, f, regno):
> +        self.decl_reg_num(f, regno)
> +        f.write(code_fmt(f"""\
> +            ctx_log_vreg_read(ctx, {self.reg_num});
> +        """))
> 
>  class VRegReadWrite(Register, Hvx, ReadWrite):
>      def decl_tcg(self, f, tag, regno):
> @@ -731,6 +834,13 @@ def helper_hvx_desc(self, f):
>          f.write(code_fmt(f"""\
>              /* {self.reg_tcg()} is *(MMVector *)({self.helper_arg_name()}) */
>          """))
> +    def analyze_write(self, f, tag, regno):
> +        self.decl_reg_num(f, regno)
> +        newv = hvx_newv(tag)
> +        predicated = "true" if is_predicated(tag) else "false"
> +        f.write(code_fmt(f"""\
> +            ctx_log_vreg_write(ctx, {self.reg_num}, {newv}, {predicated});
> +        """))
> 
>  class VRegTmp(Register, Hvx, ReadWrite):
>      def decl_tcg(self, f, tag, regno):
> @@ -755,6 +865,13 @@ def helper_hvx_desc(self, f):
>          f.write(code_fmt(f"""\
>              /* {self.reg_tcg()} is *(MMVector *)({self.helper_arg_name()}) */
>          """))
> +    def analyze_write(self, f, tag, regno):
> +        self.decl_reg_num(f, regno)
> +        newv = hvx_newv(tag)
> +        predicated = "true" if is_predicated(tag) else "false"
> +        f.write(code_fmt(f"""\
> +            ctx_log_vreg_write(ctx, {self.reg_num}, {newv}, {predicated});
> +        """))
> 
>  class VRegPairDest(Register, Hvx, Dest):
>      def decl_tcg(self, f, tag, regno):
> @@ -774,6 +891,13 @@ def helper_hvx_desc(self, f):
>          f.write(code_fmt(f"""\
>              /* {self.reg_tcg()} is *(MMVectorPair 
> *)({self.helper_arg_name()}) */
>          """))
> +    def analyze_write(self, f, tag, regno):
> +        self.decl_reg_num(f, regno)
> +        newv = hvx_newv(tag)
> +        predicated = "true" if is_predicated(tag) else "false"
> +        f.write(code_fmt(f"""\
> +            ctx_log_vreg_write_pair(ctx, {self.reg_num}, {newv}, 
> {predicated});
> +        """))
> 
>  class VRegPairSource(Register, Hvx, OldSource):
>      def decl_tcg(self, f, tag, regno):
> @@ -797,6 +921,11 @@ def helper_hvx_desc(self, f):
>          f.write(code_fmt(f"""\
>              /* {self.reg_tcg()} is *(MMVectorPair 
> *)({self.helper_arg_name()}) */
>          """))
> +    def analyze_read(self, f, regno):
> +        self.decl_reg_num(f, regno)
> +        f.write(code_fmt(f"""\
> +            ctx_log_vreg_read_pair(ctx, {self.reg_num});
> +        """))
> 
>  class VRegPairReadWrite(Register, Hvx, ReadWrite):
>      def decl_tcg(self, f, tag, regno):
> @@ -825,6 +954,13 @@ def helper_hvx_desc(self, f):
>          f.write(code_fmt(f"""\
>              /* {self.reg_tcg()} is *(MMVectorPair 
> *)({self.helper_arg_name()}) */
>          """))
> +    def analyze_write(self, f, tag, regno):
> +        self.decl_reg_num(f, regno)
> +        newv = hvx_newv(tag)
> +        predicated = "true" if is_predicated(tag) else "false"
> +        f.write(code_fmt(f"""\
> +            ctx_log_vreg_write_pair(ctx, {self.reg_num}, {newv}, 
> {predicated});
> +        """))
> 
>  class QRegDest(Register, Hvx, Dest):
>      def decl_tcg(self, f, tag, regno):
> @@ -844,6 +980,11 @@ def helper_hvx_desc(self, f):
>          f.write(code_fmt(f"""\
>              /* {self.reg_tcg()} is *(MMQReg *)({self.helper_arg_name()}) */
>          """))
> +    def analyze_write(self, f, tag, regno):
> +        self.decl_reg_num(f, regno)
> +        f.write(code_fmt(f"""\
> +            ctx_log_qreg_write(ctx, {self.reg_num});
> +        """))
> 
>  class QRegSource(Register, Hvx, OldSource):
>      def decl_tcg(self, f, tag, regno):
> @@ -861,6 +1002,11 @@ def helper_hvx_desc(self, f):
>          f.write(code_fmt(f"""\
>              /* {self.reg_tcg()} is *(MMQReg *)({self.helper_arg_name()}) */
>          """))
> +    def analyze_read(self, f, regno):
> +        self.decl_reg_num(f, regno)
> +        f.write(code_fmt(f"""\
> +            ctx_log_qreg_read(ctx, {self.reg_num});
> +        """))
> 
>  class QRegReadWrite(Register, Hvx, ReadWrite):
>      def decl_tcg(self, f, tag, regno):
> @@ -883,6 +1029,11 @@ def helper_hvx_desc(self, f):
>          f.write(code_fmt(f"""\
>              /* {self.reg_tcg()} is *(MMQReg *)({self.helper_arg_name()}) */
>          """))
> +    def analyze_write(self, f, tag, regno):
> +        self.decl_reg_num(f, regno)
> +        f.write(code_fmt(f"""\
> +            ctx_log_qreg_write(ctx, {self.reg_num});
> +        """))
> 
>  def init_registers():
>      regs = {
> --
> 2.34.1

Reviewed-by: Brian Cain <bcain@quicinc.com>