[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v3 04/30] io: fsync before closing a file channel
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [RFC PATCH v3 04/30] io: fsync before closing a file channel |
|
Date: |
Fri, 12 Jan 2024 10:40:28 +0000 |
|
User-agent: |
Mutt/2.2.10 (2023-03-25) |
On Fri, Jan 12, 2024 at 08:01:36AM +0800, Peter Xu wrote:
> On Thu, Jan 11, 2024 at 03:46:02PM -0300, Fabiano Rosas wrote:
> > > (1) Does this apply to all io channel users, or only migration?
> >
> > All file channel users.
>
> I meant the whole idea of flushing on close, on whether there will be
> iochannel users that will prefer not do so? It's a matter of where to put
> this best.
IMHO, all users of QIOChannelFile will benefit from flushing, to ensure
integrity of their saved file upon host crash.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|