qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2] hmp: Drop unknown feature and status bits


From: Yong Huang
Subject: Re: [PATCH v2 2/2] hmp: Drop unknown feature and status bits
Date: Fri, 12 Jan 2024 22:58:28 +0800



On Fri, Jan 12, 2024 at 10:04 PM Markus Armbruster <armbru@redhat.com> wrote:
Hyman Huang <yong.huang@smartx.com> writes:

> The QMP command "x-query-virtio-status" outputs the full
> feature and status bit information, so there is no need
> to maintain it in the HMP output; drop it.
>
> Signed-off-by: Hyman Huang <yong.huang@smartx.com>

I'm not sure hiding unknown bits from HMP users is a good idea.  Sure,
you can use QMP to find them, but why would you when HMP gives no clue
that its output is incomplete?

I'd simply keep them, i.e. drop this patch.


Ok, I'm not insisting on that.

Thanks, 
Yong

--
Best regards

reply via email to

[Prev in Thread] Current Thread [Next in Thread]