[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] Optimize buffer_is_zero
|
From: |
Alexander Monakov |
|
Subject: |
Re: [PATCH v2] Optimize buffer_is_zero |
|
Date: |
Sun, 14 Jan 2024 21:27:00 +0300 (MSK) |
On Tue, 9 Jan 2024, Daniel P. Berrangé wrote:
> On Thu, Nov 09, 2023 at 03:52:38PM +0300, Alexander Monakov wrote:
> > I'd like to ping this patch on behalf of Mikhail.
> >
> > https://patchew.org/QEMU/20231027143704.7060-1-mmromanov@ispras.ru/
> >
> > If this needs to be split up a bit to ease review, please let us know.
>
> Sorry, my asm knowledge isn't strong enough for me to review this.
> Reading the commit message though, how it describes 8 separate changes
> does make me believe this should be done as a series of 8 patches.
(I'm not sure where the number 8 comes from, the enumeration in the commit
message goes up to eleven)
> It would make it easier to review and/or spot any accidental
> regressions, etc .
Paolo and Richard, can you please confirm if you'll be more likely to engage
with this optimization when it's resent in a broken-up form?
Thanks.
Alexander