Re: [RFC PATCH v3 04/30] io: fsync before closing a file channel

[Peter Xu]

On Thu, Jan 11, 2024 at 03:46:02PM -0300, Fabiano Rosas wrote:
> > (2) Why metadata doesn't matter (v.s. fsync(), when CONFIG_FDATASYNC=y)?
> 
> Syncing the inode information is not critical, it's mostly timestamp
> information (man inode). And fdatasync makes sure to sync any metadata
> that would be relevant for the retrieval of the data.

I forgot to reply to this one in the previous reply..

Timestamps look all fine to be old.  What about file size?  That's also in
"man inode" as metadata, but I'm not sure whether data will be fully valid
if e.g. size enlarged but not flushed along with the page caches.

-- 
Peter Xu