Re: [PATCH v4 37/45] Add mailbox tests tags. Part 1

[Peter Maydell]

On Fri, 8 Dec 2023 at 02:38, Sergey Kambalin <serg.oker@gmail.com> wrote:
>
> Signed-off-by: Sergey Kambalin <sergey.kambalin@auriga.com>
> ---
>  tests/qtest/bcm2838-mailbox.h | 195 +++++++++++++++++++++++++++++++++-
>  1 file changed, 190 insertions(+), 5 deletions(-)
>
> diff --git a/tests/qtest/bcm2838-mailbox.h b/tests/qtest/bcm2838-mailbox.h
> index 8acc4bd2ff..04472fe23d 100644
> --- a/tests/qtest/bcm2838-mailbox.h
> +++ b/tests/qtest/bcm2838-mailbox.h
> @@ -147,13 +147,21 @@
>  /* Used to test stubs that don't perform actual work */
>  #define DUMMY_VALUE 0x12345678
>
> -REG32(MBOX_WRITE_REG, 0)
> +REG32(MBOX_WRITE_REG,          0)
>  FIELD(MBOX_WRITE_REG, CHANNEL, 0, 4)
> -FIELD(MBOX_WRITE_REG, DATA, 4, 28)
> +FIELD(MBOX_WRITE_REG, DATA,    4, 28)

I don't strongly care whether you like to line up the
macro argument fields or not, but please pick something
and stick to it, rather than doing it one way to start
and then making whitespace changes in a later patch.

> -REG32(MBOX_SIZE_STAT, 0)
> -FIELD(MBOX_WRITE_REG, SIZE, 0, 30)
> -FIELD(MBOX_WRITE_REG, SUCCESS, 30, 1)
> +REG32(MBOX_SIZE_STAT,          0)
> +FIELD(MBOX_SIZE_STAT, SIZE,    0, 30)
> +FIELD(MBOX_SIZE_STAT, SUCCESS, 30, 1)
> +
> +REG32(SET_DEVICE_POWER_STATE_CMD,        0)
> +FIELD(SET_DEVICE_POWER_STATE_CMD, EN,    0, 1)
> +FIELD(SET_DEVICE_POWER_STATE_CMD, WAIT,  1, 1)
> +
> +REG32(GET_CLOCK_STATE_CMD,        0)
> +FIELD(GET_CLOCK_STATE_CMD, EN,    0, 1)
> +FIELD(GET_CLOCK_STATE_CMD, NPRES, 1, 1)
>
>  typedef struct {

thanks
-- PMM