Re: [PATCH] hw/arm/virt.c: Remove newline from error_report() string

[Philippe Mathieu-Daudé]

On 18/1/24 16:17, Philippe Mathieu-Daudé wrote:
> On 18/1/24 14:16, Peter Maydell wrote:
> > error_report() strings should not include trailing newlines; remove
> > the newline from the error we print when devices won't fit into the
> > address space of the CPU.
> >
> > This commit also fixes the accidental hardcoded tabs that were in
> > this line, since we have to touch the line anyway.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> >   hw/arm/virt.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

BTW there is another case:

$ spatch \
  --macro-file scripts/cocci-macro-file.h \
  --sp-file scripts/coccinelle/err-bad-newline.cocci \
  --keep-comments --use-gitgrep --dir .
./hw/arm/virt.c:1775:38:"Addressing limited to %d bits, but memory 
exceeds it by %llu bytes\n"
./ui/gtk.c:1094:56:"gtk: unexpected touch event type\n"

We could run this some of these coccinelle scripts on CI,
as a new job in .gitlab-ci.d/static_checks.yml or extending
the check-patch job...

Patch on the way for ui/gtk.c.