[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 0/6] virtio-blk: iothread-vq-mapping cleanups
|
From: |
Stefan Hajnoczi |
|
Subject: |
[PATCH 0/6] virtio-blk: iothread-vq-mapping cleanups |
|
Date: |
Fri, 19 Jan 2024 08:57:42 -0500 |
Kevin Wolf identified some issues with the virtio-blk iothread-vq-mapping patch
series that was merged at the end of 2023:
1. s->rq is restarted from one AioContext and races with the other
iothread-vq-mapping AioContexts.
2. Failure to set the AioContext is no longer fatal since the IO_CODE APIs can
be called from any thread. We can relax the error handling behavior.
3. Starting dataplane must self-trigger the ioeventfd even in a drained
section. Failure to do so could lead to an unresponsive virtio-blk device.
This patch series addresses these issues. The first few patches merge the
hw/block/dataplane/virtio-blk.c code into hw/block/virtio-blk.c so that s->rq
can easily be restarted in the correct AioContexts.
Stefan Hajnoczi (6):
virtio-blk: move dataplane code into virtio-blk.c
virtio-blk: rename dataplane create/destroy functions
virtio-blk: rename dataplane to ioeventfd
virtio-blk: restart s->rq reqs in vq AioContexts
virtio-blk: tolerate failure to set BlockBackend AioContext
virtio-blk: always set ioeventfd during startup
meson.build | 1 -
hw/block/dataplane/trace.h | 1 -
hw/block/dataplane/virtio-blk.h | 34 ---
include/hw/virtio/virtio-blk.h | 16 +-
hw/block/dataplane/virtio-blk.c | 404 -------------------------------
hw/block/virtio-blk.c | 412 +++++++++++++++++++++++++++++---
hw/block/dataplane/meson.build | 1 -
hw/block/dataplane/trace-events | 5 -
8 files changed, 391 insertions(+), 483 deletions(-)
delete mode 100644 hw/block/dataplane/trace.h
delete mode 100644 hw/block/dataplane/virtio-blk.h
delete mode 100644 hw/block/dataplane/virtio-blk.c
delete mode 100644 hw/block/dataplane/trace-events
--
2.43.0
- [PATCH 0/6] virtio-blk: iothread-vq-mapping cleanups,
Stefan Hajnoczi <=
- [PATCH 2/6] virtio-blk: rename dataplane create/destroy functions, Stefan Hajnoczi, 2024/01/19
- [PATCH 3/6] virtio-blk: rename dataplane to ioeventfd, Stefan Hajnoczi, 2024/01/19
- [PATCH 4/6] virtio-blk: restart s->rq reqs in vq AioContexts, Stefan Hajnoczi, 2024/01/19
- [PATCH 1/6] virtio-blk: move dataplane code into virtio-blk.c, Stefan Hajnoczi, 2024/01/19
- [PATCH 5/6] virtio-blk: tolerate failure to set BlockBackend AioContext, Stefan Hajnoczi, 2024/01/19
- [PATCH 6/6] virtio-blk: always set ioeventfd during startup, Stefan Hajnoczi, 2024/01/19
- Re: [PATCH 0/6] virtio-blk: iothread-vq-mapping cleanups, Kevin Wolf, 2024/01/19