[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/15] Hexagon (target/hexagon) Fix shadow variable when idef-pars
|
From: |
Brian Cain |
|
Subject: |
[PULL 02/15] Hexagon (target/hexagon) Fix shadow variable when idef-parser is off |
|
Date: |
Sun, 21 Jan 2024 22:34:48 -0800 |
From: Taylor Simpson <ltaylorsimpson@gmail.com>
Adding -Werror=shadow=compatible-local causes Hexagon not to build
when idef-parser is off. The "label" variable in CHECK_NOSHUF_PRED
shadows a variable in the surrounding code.
Signed-off-by: Taylor Simpson <ltaylorsimpson@gmail.com>
Reviewed-by: Brian Cain <bcain@quicinc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20231130183955.54314-1-ltaylorsimpson@gmail.com>
Signed-off-by: Brian Cain <bcain@quicinc.com>
---
target/hexagon/macros.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h
index 9a51b5709b..f99390e2a8 100644
--- a/target/hexagon/macros.h
+++ b/target/hexagon/macros.h
@@ -93,13 +93,13 @@
#define CHECK_NOSHUF_PRED(GET_EA, SIZE, PRED) \
do { \
- TCGLabel *label = gen_new_label(); \
- tcg_gen_brcondi_tl(TCG_COND_EQ, PRED, 0, label); \
+ TCGLabel *noshuf_label = gen_new_label(); \
+ tcg_gen_brcondi_tl(TCG_COND_EQ, PRED, 0, noshuf_label); \
GET_EA; \
if (insn->slot == 0 && ctx->pkt->pkt_has_store_s1) { \
probe_noshuf_load(EA, SIZE, ctx->mem_idx); \
} \
- gen_set_label(label); \
+ gen_set_label(noshuf_label); \
if (insn->slot == 0 && ctx->pkt->pkt_has_store_s1) { \
process_store(ctx, 1); \
} \
--
2.25.1
- [PULL 00/15] target-hexagon queue, hexagon docker, Brian Cain, 2024/01/22
- [PULL 05/15] Hexagon (target/hexagon) Make generators object oriented - gen_helper_protos, Brian Cain, 2024/01/22
- [PULL 03/15] Hexagon (target/hexagon) Clean up handling of modifier registers, Brian Cain, 2024/01/22
- [PULL 07/15] Hexagon (target/hexagon) Make generators object oriented - gen_idef_parser_funcs, Brian Cain, 2024/01/22
- [PULL 02/15] Hexagon (target/hexagon) Fix shadow variable when idef-parser is off,
Brian Cain <=
- [PULL 08/15] Hexagon (target/hexagon) Make generators object oriented - gen_op_regs, Brian Cain, 2024/01/22
- [PULL 13/15] Hexagon (target/hexagon) Use QEMU decodetree (16-bit instructions), Brian Cain, 2024/01/22
- [PULL 09/15] Hexagon (target/hexagon) Make generators object oriented - gen_analyze_funcs, Brian Cain, 2024/01/22
- [PULL 15/15] target/hexagon: reduce scope of def_regnum, remove dead assignment, Brian Cain, 2024/01/22
- [PULL 01/15] tests/docker: Hexagon toolchain update, Brian Cain, 2024/01/22
- [PULL 10/15] Hexagon (target/hexagon) Remove unused WRITES_PRED_REG attribute, Brian Cain, 2024/01/22
- [PULL 14/15] Hexagon (target/hexagon) Remove old dectree.py, Brian Cain, 2024/01/22
- [PULL 12/15] Hexagon (target/hexagon) Use QEMU decodetree (32-bit instructions), Brian Cain, 2024/01/22
- [PULL 04/15] Hexagon (target/hexagon) Make generators object oriented - gen_tcg_funcs, Brian Cain, 2024/01/22
- [PULL 06/15] Hexagon (target/hexagon) Make generators object oriented - gen_helper_funcs, Brian Cain, 2024/01/22