[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 08/10] migration/yank: Use channel features
|
From: |
Fabiano Rosas |
|
Subject: |
Re: [PATCH v6 08/10] migration/yank: Use channel features |
|
Date: |
Mon, 22 Jan 2024 17:08:09 -0300 |
Peter Xu <peterx@redhat.com> writes:
> On Mon, Sep 11, 2023 at 02:13:18PM -0300, Fabiano Rosas wrote:
>> Stop using outside knowledge about the io channels when registering
>> yank functions. Query for features instead.
>>
>> The yank method for all channels used with migration code currently is
>> to call the qio_channel_shutdown() function, so query for
>> QIO_CHANNEL_FEATURE_SHUTDOWN. We could add a separate feature in the
>> future for indicating whether a channel supports yanking, but that
>> seems overkill at the moment.
>>
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>
> Reviewed-by: Peter Xu <peterx@redhat.com>
Hi Peter, this one has fell through the cracks, think we could merge it?
- Re: [PATCH v6 08/10] migration/yank: Use channel features,
Fabiano Rosas <=